196735 – [Schema][Editor] Source page should be named "Source"

Bug 196735 - [Schema][Editor] Source page should be named "Source"

Summary: [Schema][Editor] Source page should be named "Source"

Status:	RESOLVED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.3
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	3.4 M1
Assignee:	Adam Archer
QA Contact:

URL:
Whiteboard:
Keywords:	contributed

Depends on:
Blocks:

Reported:	2007-07-16 17:15 EDT by Noam Chitayat
Modified:	2007-07-17 09:50 EDT (History)
CC List:	2 users (show)

See Also:

Flags:	mike.pawlowski: review? (wassim.melhem)

Attachments
patch (3.67 KB, patch) 2007-07-17 08:17 EDT, Adam Archer	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Noam Chitayat

2007-07-16 17:15:28 EDT

Build ID: I20070625-1500

The source page tab in the schema editor currently uses as its name the name of the schema file. It should just say "Source".

Comment 1 Mike Pawlowski

2007-07-16 17:18:12 EDT

I agree.  Good catch Noam.  Wassim do you concur?  I already do this for the Simple Cheat Sheet Editor.

Comment 2 Wassim Melhem

2007-07-16 17:19:54 EDT

right.  Editors with only one input should have the source page named 'Source'.

Let's give it to Adam since he's in that area.

Comment 3 Noam Chitayat

2007-07-16 17:32:35 EDT

While here, we should rename PDEUIMessages.SimpleCSSourcePage_pageNameSource to make it more generic, since multiple editors (CS, TOC, Schema and possibly more in future) will be using it.

Comment 4 Adam Archer

2007-07-16 17:37:01 EDT

(In reply to comment #3)
Good idea Noam. I'll make sure this gets in the patch.

Comment 5 Adam Archer

2007-07-17 08:17:32 EDT

Created attachment 73939 [details]
patch

This patch renames the page to "Source" and refactors the message as suggested in comment 3 (to "EditorSourcePage_name"). When this patch is applied I imagine that the reference to the message from the toc editor will need to be updated accordingly.

Comment 6 Wassim Melhem

2007-07-17 09:50:41 EDT

Thanks.  Released the patch.  However, at some point, I think we need to refactor since many editors (toc, 2 cheatsheets, schema, standalone build.properties) need something similar.