Bug 196734 - Target Editor "Additional Locations" list should consume vertical whitespace
Summary: Target Editor "Additional Locations" list should consume vertical whitespace
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M2   Edit
Assignee: bartosz michalik CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2007-07-16 17:14 EDT by Simon Archer CLA
Modified: 2007-08-15 17:29 EDT (History)
3 users (show)

See Also:
baumanbr: review+


Attachments
example of how to resize this section (1.51 KB, patch)
2007-08-03 16:03 EDT, bartosz michalik CLA
no flags Details | Diff
path for the right component ;) (4.73 KB, patch)
2007-08-07 06:03 EDT, bartosz michalik CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Archer CLA 2007-07-16 17:14:59 EDT
The Target Editor's Overview page has a section titled "Additional Locations".  This section contains a list, but sadly since the section does not consume the available vertical whitespace, you get scrollbars if you have more than 4 items in the list.

Please make the "Additional Locations" section consume all, or more of, the available vertical whitespace.
Comment 1 Wassim Melhem CLA 2007-07-16 17:17:17 EDT
how many locations do you have?  a thousand? ;)
Comment 2 Simon Archer CLA 2007-07-16 17:35:33 EDT
Not quite thousands... In one case we have 6 additional locations.  But nevertheless, whenever there's a list widget and available vertical whitespace, I like the list to be whitespace-greedy.
Comment 3 Wassim Melhem CLA 2007-07-19 15:45:31 EDT
Adam Archer, meet Simon Archer.
Comment 4 Simon Archer CLA 2007-07-19 18:41:35 EDT
Adam: In addition to sharing your name, I'm a member of "The Friends of PDE"... don't let anyone tell you otherwise.  ;-)
Comment 5 Wassim Melhem CLA 2007-07-31 09:09:27 EDT
Brian to assist Bartek and review his patch.
Comment 6 bartosz michalik CLA 2007-08-03 16:03:09 EDT
Created attachment 75361 [details]
example of how to resize this section


Overview page is controlled by TableWrapLayout 
and to compare extensions page is controlled by GridLayout which allows components to expand to all available space
The only thing I've been able to do was to resize it to static specified height in table wrap layout. 
please correct me if I'm wrong.
Comment 7 Chris Aniszczyk CLA 2007-08-05 15:26:40 EDT
Brian, please review.
Comment 8 Chris Aniszczyk CLA 2007-08-05 15:26:56 EDT
adding contributed keyword
Comment 9 Brian Bauman CLA 2007-08-06 12:56:44 EDT
Hi Bartosz, unfortunately I think there was a miscommunication on what section needed to be edited.  

The patch you supplied is for the Plug-in Manifest Editor.  The editor in question is the Target Definition Editor.  To open the editor, you can create a new Target Definition (New > Other > Target Definition).

In this editor, in the middle of the Overview page there is an Additional Locations section.  This is the section in discussed in the bug report.  The class for this section is org.eclipse.pde.internal.ui.editor.target.LocationsSection.

If you have any questions about this class or the Target Editor, please don't hesitate to post them.
Comment 10 bartosz michalik CLA 2007-08-07 06:03:35 EDT
Created attachment 75515 [details]
path for the right component ;)

This is a path for the right editor. Sorry for last misunderstanding.
I'm waiting for change suggestions if any.
Comment 11 Brian Bauman CLA 2007-08-15 17:29:00 EDT
Bartosz, sorry about not applying this patch right away.  It plays very well with the editor.  The only thing thing I fixed were some really minor spacing issues.  Thanks a lot!