Bug 196715 - [RulersGrid] Grid spacing in inches even though page size is centimetres
Summary: [RulersGrid] Grid spacing in inches even though page size is centimetres
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: 2.1   Edit
Assignee: Carson Li CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-07-16 15:11 EDT by Anthony Hunter CLA
Modified: 2010-07-19 21:58 EDT (History)
1 user (show)

See Also:


Attachments
Proposed patch (2.26 KB, patch)
2007-11-06 15:18 EST, Carson Li CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Hunter CLA 2007-07-16 15:11:19 EDT
Since we can detect what locale we are in, if the page size is A4/centimeters the grid should also be centimetres.
Comment 1 Carson Li CLA 2007-10-12 14:58:44 EDT
(In reply to comment #0)
> Since we can detect what locale we are in, if the page size is A4/centimeters
> the grid should also be centimetres.
> 

from what I see, despite the page size, the unit will always either be in inches or millimeters. furthermore taking a closer look at DefaultValues.java , inches will always be set to default. 

the locale will only affect page size, that is US / Canada = Letter, 
everything else being A4

the property section for grids and rulers only support inches, centimeters, and pixels, so i'm not sure it logically makes sense to change everything (even though the fix should be very simple should there be one)

what we could do is follow along with the default values, that is, if it's US/Canada, we default to inches for rulers and grids. otherwise we default to centimeters (notice no matter what, the page would still either be in inches or millimeters)
Comment 2 Anthony Hunter CLA 2007-11-01 13:55:50 EDT
(In reply to comment #1)
> what we could do is follow along with the default values, that is, if it's
> US/Canada, we default to inches for rulers and grids. otherwise we default to
> centimeters (notice no matter what, the page would still either be in inches or
> millimeters)
> 

Exactly what I think we want.
Comment 3 Carson Li CLA 2007-11-06 15:18:09 EST
Created attachment 82259 [details]
Proposed patch

Added a simple check to the rulers RulerGridPreferencePage.  Checks if locale is us/canada, is so, set default to inches, otherwise, it's centimeters
Comment 4 Anthony Hunter CLA 2007-11-16 15:03:33 EST
Committed to HEAD
Comment 5 Anthony Hunter CLA 2007-11-16 15:03:52 EST
Committed to HEAD
Comment 6 Richard Gronback CLA 2008-08-13 13:08:36 EDT
[target cleanup] 2.1 M4 was the original target milestone for this bug
Comment 7 Eclipse Webmaster CLA 2010-07-19 21:58:34 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Runtime was the original product and component for this bug