Community
Participate
Working Groups
Craig Setera wrote: I'm playing with Target Management and I definitely like the concept. I created an FTP connection to my web hosting site and specified a passive connection. It worked fine for a while, but now it won't work anymore. If I look in the properties, I see that it is still specified as passive, but TM is always initiating a non-passive connection and I get: PORT 192,168,0,22,14,66 500 I won't open a connection to 192.168.0.22 (only to xxx.xxx.xxx.xxx) in the console. -----------Enter bugs above this line----------- TM 2.0 installation : eclipse-SDK-3.3 (I20070625-1500), cdt-4.0.0, emf-2.3.0 RSE install : workspace HEAD java.runtime : Sun 1.6.0_01-b06 os.name: : Windows XP 5.1, Service Pack 1 ------------------------------------------------ systemtype : Windows-local, Dstore-win, Dstore-linux targetos : Red Hat Enterprise Linux WS release 4 (Nahant Update 3) targetuname : Linux parser 2.6.9-34.EL #1 i686 athlon i386 GNU/Linux targetvm : Sun Java HotSpot(TM) Client VM (build 1.4.2_12-b03, mixed mode) ------------------------------------------------
I could reproduce this issue and it looks like a bug. When I look into the Subsystem Properties, it says "passive"="true" but according to FTP Console it does not initiate a passive mode connection. Switching subsystem properties to "false" and back to "true" does not help. This might be a problem with instantiating the PropertySet at the wrong time, and using a wrong propertySet in the ConnectorService (since the correct one appears to be used in the Property Page). Adding Dave D on CC. For me, it looks like FTPConnectorSerivice.java line 99, _ftpService.setPropertySet(_propertySet); should be changed to _ftpService.setPropertySet(getPropertySet("FTP Settings"));
It looks like a change of behaviour in the PropertySets during the wizard. Debugging it, getPropertySet("FTP Settings") returns null, even after having filled the properties in the wizard page. DaveD: Do you know what could be causing it ?
I'll take a look.
Any update on this ? The FTP Properties displayed in RSE are not the same as the ones applied to the FTPClient. It means that even the user changes the active/passive mode or the parser, those changes are not applied to the FTP client.
Dave you've been most successful finding issues with the PropertySets in the past -- Javier and I both don't understand where that issue comes from. Could you please take a look. This is a major functionality issue.
The problem is that in the FTPConnectorService constructor we're trying to get the "FTP Settings" property set and store it in the _propertySet variable. What happens is, if the property set cannot be found, a default one is created. However, the property sets for a model object are not created until after the constructor for a model object is called, so we end up storing this default property set before the real one gets created and associated. Instead of creating the property set in the constructor, this should be deferred until it is needed. I'll attach a patch that describes one resolution to this problem.
(In reply to comment #4) > Any update on this ? > > The FTP Properties displayed in RSE are not the same as the ones applied to the > FTPClient. > It means that even the user changes the active/passive mode or the parser, > those changes are not applied to the FTP client. >
Created attachment 75052 [details] patch to review
With the patch, the "FTP Settings" PropertySet is no longer available, neither in the FTP wizard or in the the subsystem properties. Any idea ?
Created attachment 75066 [details] updated patch Try this. I think the problem was that the property isn't created initially when you have the wizard. This update doesn't store the property set separately so we update the proper one.
Now the settings specified on the wizard are not moved to the created FTP connection. To reproduce, create a new FTP connection and modify the default "FTP Settings" (passive and/or parser) Once created, the FTP Settings are reset to the default ones.
It seems okay to me. Are you seeing this when you open up the property page after creating the connection?
Hmm, sometimes this works and other times it doesn't. This is looking like it's intermittent.
Created attachment 75077 [details] updated patch dealing with wizard selection issues
There appears to be an additional problem with the wizard here. Properties were not being applied in the wizard because selected ServiceElements did not have their _isSelected property set properly. Does this work for you?
It works fine now. The property set in the wizard is correctly moved to the created FTP client. I'll apply the patch, thanks !
Now the FTP settings of the wizard are passed to the created connection.
