Bug 196378 - [Search] Entering an archive extension in File name patterns should check "Search Archive Files"
Summary: [Search] Entering an archive extension in File name patterns should check "Se...
Status: RESOLVED WONTFIX
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Kevin Doyle CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-12 16:31 EDT by Kevin Doyle CLA
Modified: 2007-07-13 11:45 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Doyle CLA 2007-07-12 16:31:48 EDT
If you enter in the file name patterns text box of the Search dialog the extension of an archive handler then it should check the "Search Archive files" check box.  

Example:
File name patterns: *.zip, rse.zip

This means we want to search zip files, so Search Archive files should be checked.

This bug was created from the discussion of bug #187427.

-----------Enter bugs above this line-----------
TM 2.0 Testing
installation : eclipse-SDK-3.3
RSE install  : RSE 2.0
java.runtime : Sun 1.5.0_11-b03
os.name:     : Windows XP, Service Pack 2
------------------------------------------------
Comment 1 Martin Oberhuber CLA 2007-07-13 06:50:27 EDT
I'm against too much magic and automatic checking of checkboxes in dialogs.
This can become confusing.

Imagine, for instance, a user editing the "search" field and adding then removing the *.zip pattern. Or, doing copy&paste first with then without a *.zip pattern. Would you always check/uncheck the checkbox?

When manually filling the dialog, users should tell us what they want and we'll do it. It's different when we prefill the dialog based on some context selection as requested in bug #187427 -- in that case, we prefill the dialog ONCE with useful values but don't interfere afterwards.

Kevin, Xuan, what do you think? Are you OK with marking this WONTFIX?
Comment 2 Martin Oberhuber CLA 2007-07-13 06:52:07 EDT
BTW, it's even more confusing when the "Search String" is empty so we are only looking for file name matches.

In this case, pattern *.zip could mean find all *.zip files but it could also mean find *.zip files and/or *.zip files embedded inside other *.zip files. One reason more for not checking the box automatically.
Comment 3 Kevin Doyle CLA 2007-07-13 09:53:23 EDT
I agree.  I wasn't to sure about this in the beginning, but after reading your comments I don't think we should do this.  

Will wait for Xuan's comments before marking WONTFIX.
Comment 4 Xuan Chen CLA 2007-07-13 11:41:38 EDT
I agree that it could cause more confusion in some cases.

Please mark it as WONFIX.  Thanks.
Comment 5 Kevin Doyle CLA 2007-07-13 11:45:34 EDT
Marking WONTFIX.