Bug 196240 - [Manifest][Editors] Section text is wrong when adding a new element
Summary: [Manifest][Editors] Section text is wrong when adding a new element
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Adam Archer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-07-11 18:05 EDT by Mike Pawlowski CLA
Modified: 2007-07-17 15:03 EDT (History)
1 user (show)

See Also:
mike.pawlowski: review+

Attachments
patch (1.10 KB, patch)
2007-07-17 08:49 EDT, Adam Archer CLA 		mike.pawlowski: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Pawlowski CLA 2007-07-11 18:05:46 EDT 
Final 3.3 Release (Build id: I20070625-1500)

Steps To Reproduce:

(1) Open a plug-in manifest editor
(2) Switch to "Extensions" page
(3) Add "org.eclipse.ui.editors" extension
(4) Select the new extension
(5) Right-click and select "New > editor" from the context menu
    -> New "editor" element is now selected
    -> Observe the "Extension Element Details" section
    -> BUG:  The section description says 
       "The selected element has no properties to set."
(6) Select another element or extension
(7) Reselect the "editor" element
    -> Section description is correct now:
       "Set the properties of "editor". Required fields are denoted by "*"."

The only time we should see "The selected element has no properties to set."
is when the element defines no attributes (only child elements).
Comment 1 Adam Archer CLA 2007-07-17 08:49:30 EDT 
Created attachment 73940 [details]
patch

Attributes were being inserted into the new element after it was added to the parent extension. Reversing the order corrects the problem.
Comment 2 Mike Pawlowski CLA 2007-07-17 15:02:53 EDT 
Comment on attachment 73940 [details]
patch

Nice patch.  Thanks Adam.  We lose the cool effect of all the applicable child elements being auto-generated and added to the tree viewer and expanded (last element is selected); however, current behaviour of selecting the first element added makes more sense.
Comment 3 Mike Pawlowski CLA 2007-07-17 15:03:38 EDT 
Patch applied to HEAD.

Target:  3.4 M1