Bug 196227 - [Manifest][Editors] Remove "Extension..." menu entry from Extensions tree viewer context menu
Summary: [Manifest][Editors] Remove "Extension..." menu entry from Extensions tree vie...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Adam Archer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-07-11 16:35 EDT by Mike Pawlowski CLA
Modified: 2007-07-16 18:10 EDT (History)
1 user (show)

See Also:
mike.pawlowski: review+

Attachments
patch (984 bytes, patch)
2007-07-16 12:27 EDT, Adam Archer CLA 		no flags Details | Diff
better patch (1.91 KB, patch)
2007-07-16 16:08 EDT, Adam Archer CLA 		mike.pawlowski: review+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Pawlowski CLA 2007-07-11 16:35:32 EDT 
"Extensions" page > "All Extensions" section > tree viewer

Presenting the "Extension..." menu entry in the context menu is confusing because it suggests that a new extension will be created as a child of the currently selected element or extension (e.g. in it's hierarchy).  Instead an extension is added globally.

Remove the "Extension..." menu entry from the context menu of selected elements and extensions.
Comment 1 Adam Archer CLA 2007-07-16 12:27:28 EDT 
Created attachment 73862 [details]
patch

This patch removes the "Extension..." option from the new sub-menu in the context menu. Due to a recent regression (since 3.3) this currently means that the menu will be empty and will therefore not display at all. Once the regression is corrected and extensions again report their children, the menu will contain only the  selected extension's potential children.
Comment 2 Adam Archer CLA 2007-07-16 16:08:37 EDT 
Created attachment 73894 [details]
better patch

The patch functionality is identical. The previous patch left some dead code in, however.
Comment 3 Mike Pawlowski CLA 2007-07-16 18:09:42 EDT 
Comment on attachment 73894 [details]
better patch

Tested well and context menu much cleaner.  Thanks Adam.
Comment 4 Mike Pawlowski CLA 2007-07-16 18:10:23 EDT 
Patch released to HEAD.

Target:  3.4 M1