Bug 196226 - [Schema][Editors] Reorganize tree viewer context menu entries
Summary: [Schema][Editors] Reorganize tree viewer context menu entries
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Adam Archer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-07-11 16:02 EDT by Mike Pawlowski CLA
Modified: 2007-07-12 16:15 EDT (History)
1 user (show)

See Also:
mike.pawlowski: review+


Attachments
patch (6.09 KB, patch)
2007-07-12 11:27 EDT, Adam Archer CLA
mike.pawlowski: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Pawlowski CLA 2007-07-11 16:02:04 EDT
The context menu in the "Extension Point Elements" tree viewer on the "Definition" form page has the following problems:

(1) Uses one unnecessary level of sub-menus
(2) Includes menu items that are not part of the hierarchy in the given context

New Context Menu Layout:

* Extension Element selection:

  New > Choice
        Sequence

  If the extension element already has a choice or sequence, 
  the "New" submenu should not be added to the context menu
  (no "New" menu entries as choice and sequence are not applicable
  in this context)

  Important:  Update the enablement of the "New Sequence" and "New Choice"
  buttons accordingly (e.g. disable them if a compositor already exists).

  Note: "Element" menu entry should be removed; since, it adds global elements
  and is not applicable in this context.

* Extension Element Attribute selection:

  Leave as is (no "New" menu entry)  

* Element selection:

  New > Attribute
        -----------
        Choice
        Sequence

  If the element already has a choice or sequence, 
  the "Choice" and "Sequence" menu entries should be omitted as they are not
  applicable.

  Note: "Element" menu entry should be removed; since, it adds global elements
  and is not applicable in this context.

* Element Attribute selection:

  Leave as is ("New > Attribute" menu entry)  

* Element Reference selection:

  Leave as is (no "New" menu entry)  

* "Sequence" or "Choice" Compositor selection:

  New > Choice
        Sequence  
        -----------
        Element Reference # 1
        Element Reference # 2
        ...
        Element Reference # N

If anything does make sense or you see room for improvement please let me know.
Comment 1 Adam Archer CLA 2007-07-12 11:27:39 EDT
Created attachment 73676 [details]
patch

Lots of requirements in this one. I think I got them all.
Comment 2 Mike Pawlowski CLA 2007-07-12 16:14:53 EDT
Comment on attachment 73676 [details]
patch

Excellent patch Adam. Context menu is so much better now. Thanks
Comment 3 Mike Pawlowski CLA 2007-07-12 16:15:30 EDT
Patch applied to HEAD.

Target:  3.4 M1