Bug 196046 - [Schema][Editors] The DTD approximation field deserves its own section header
Summary: [Schema][Editors] The DTD approximation field deserves its own section header
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Adam Archer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-07-10 14:29 EDT by Mike Pawlowski CLA
Modified: 2007-07-17 11:46 EDT (History)
1 user (show)

See Also:
mike.pawlowski: review+


Attachments
patch (10.99 KB, patch)
2007-07-17 08:05 EDT, Adam Archer CLA
mike.pawlowski: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Pawlowski CLA 2007-07-10 14:29:01 EDT
Currently DTD approximations are shown for the following schema objects:
* Elements
* Element References
* Choice Compositors
* Sequence Compositors

Each one of the corresponding details sections has an "DTD approximation" field.
Since, this field is a not a detail that can be edited, it deserves its own section to reduce clutter.

A section called "DTD approximation" should be created under the details section of each schema object and the existing field should be moved under it.
The section description should be a brief version of the following:

"Use the read-only DTD approximation field to view an approximate one-to-one mapping of the element schema grammar to the equivalent element DTD grammar."

See the Simple Cheat Sheet Editor to see how to create multiple sections in the same details pane of the master / details block.
Comment 1 Adam Archer CLA 2007-07-17 08:05:09 EDT
Created attachment 73938 [details]
patch

This patch adds a class, SchemaDtdDetailsSection, which extends AbstractFormPart. When the dtd approximation section is requested in the constructor of AbstractSchemaDetails the section is created on the page's parent constructor. This results in the section appearing below the details section at the same level of the hierarchy.
Comment 2 Mike Pawlowski CLA 2007-07-17 11:46:13 EDT
Comment on attachment 73938 [details]
patch

Tested well.  Added null guards in various places.  Thanks Adam.
Comment 3 Mike Pawlowski CLA 2007-07-17 11:46:41 EDT
Patch released to HEAD.

Target:  3.4 M1