Bug 195778 - Silly bug in BuildEntryStorage.java
Summary: Silly bug in BuildEntryStorage.java
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-build (show other bugs)
Version: 4.0   Edit
Hardware: PC All
: P3 major (vote)
Target Milestone: 4.0.1   Edit
Assignee: Mikhail Sennikovsky CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 195569 205055 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-07-08 18:54 EDT by Sergey Prigogin CLA
Modified: 2008-06-22 02:05 EDT (History)
3 users (show)

See Also:


Attachments
Bug fix. Please apply. (1.09 KB, patch)
2007-07-08 18:56 EDT, Sergey Prigogin CLA
bjorn.freeman-benson: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Prigogin CLA 2007-07-08 18:54:17 EDT
CDT HEAD and also 4.0:

The following code in BuildEntryStorage.java is lacking "[i]" in "paths.toString()":

  ICLanguageSettingEntry entries[] = new ICLanguageSettingEntry[paths.length];
  for(int i = 0; i < paths.length; i++){
    entries[i] = (ICLanguageSettingEntry)CDataUtil.createEntry(kind, paths.toString(), null, null, flags);
  }

should be changed to:

  ICLanguageSettingEntry entries[] = new ICLanguageSettingEntry[paths.length];
  for(int i = 0; i < paths.length; i++){
    entries[i] = (ICLanguageSettingEntry)CDataUtil.createEntry(kind, paths[i].toString(), null, null, flags);
  }

This bug causes corruption of include paths returned by a custom configuration environment supplier.
Comment 1 Sergey Prigogin CLA 2007-07-08 18:56:26 EDT
Created attachment 73282 [details]
Bug fix. Please apply.
Comment 2 Sergey Prigogin CLA 2007-07-23 12:47:02 EDT
Mikhail, please review an apply the fix attached to this bugzilla.
Comment 3 Mikhail Sennikovsky CLA 2007-07-23 13:03:52 EDT
Hi Sergey,

Sorry for the delay, I've just come from vacations.. :)

I'll take a look at your patch soon

Mikhail
Comment 4 Mikhail Sennikovsky CLA 2007-07-24 12:43:29 EDT
The patch is applied.. Thanks!
Comment 5 Oleg Krasilnikov CLA 2007-09-05 09:08:30 EDT
*** Bug 195569 has been marked as a duplicate of this bug. ***
Comment 6 Mikhail Sennikovsky CLA 2007-10-01 10:25:50 EDT
*** Bug 205055 has been marked as a duplicate of this bug. ***