Bug 194464 - [telnet] Cannot create multiple telnet shells in quick succession
Summary: [telnet] Cannot create multiple telnet shells in quick succession
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2.0.1   Edit
Assignee: Sheldon CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: contributed, helpwanted
Depends on: 187301
Blocks:
  Show dependency tree
 
Reported: 2007-06-26 13:56 EDT by Martin Oberhuber CLA
Modified: 2011-05-25 09:40 EDT (History)
0 users

See Also:

Attachments
patch for bug 194464 (3.44 KB, patch)
2007-06-27 09:52 EDT, Sheldon CLA 		mober.at+eclipse: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-06-26 13:56:06 EDT 
+++ This bug was initially created as a clone of Bug #187301 +++

Found by code Review: In TelnetConnectorService, when makeNewTelnetShell() is called in quick succession by multiple threads (e.g. because a program like the Linux Shell Processes Subsystem tries to open multiple shells), the two threads can interfere because "in" and "out" are instance variables shared by the connect thread.

The streams should either be created directly in the connect thread, or passed from the master method into the connect thread through the constructor instead.
Comment 1 Sheldon CLA 2007-06-27 09:52:43 EDT 
Created attachment 72599 [details]
patch for bug 194464

the input and output streams are now passed into the connect thread from master method through the constructor.
Comment 2 Martin Oberhuber CLA 2007-07-04 11:59:36 EDT 
Patch released for 2.0.1 -- thanks!