Bug 193772 - XML Schema - "all" not available in context menus for ComplexType or Group
Summary: XML Schema - "all" not available in context menus for ComplexType or Group
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xsd (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M2   Edit
Assignee: Keith Chong CLA
QA Contact: Keith Chong CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-06-21 11:58 EDT by Joshua Gorner CLA
Modified: 2008-04-24 00:44 EDT (History)
2 users (show)

See Also:

Attachments
Patch (1.96 KB, patch)
2007-06-21 12:16 EDT, Joshua Gorner CLA 		bjorn.freeman-benson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Gorner CLA 2007-06-21 11:58:56 EDT 
Build ID: I20070323-1616

Steps To Reproduce:
1. Open an XML Schema in Design mode. Within the schema, open/create a ComplexType or Group.
2. Right-click the top of the type/group diagram, i.e. without selecting a nested attribute/element/sequence/etc.

Expected results: "Add All" is present below "Add Sequence" and "Add Choice".

Actual results: "Add All" is not present.

More information:
Note that the absence of "Add All" when right-clicking an existing sequence/choice/all item is not an error, as Schema does not support <all> nested within <sequence/choice/all> (see http://www.w3.org/TR/xmlschema-1/#Model_Groups, sec. 3.8.2).
Comment 1 Joshua Gorner CLA 2007-06-21 12:16:10 EDT 
Created attachment 72059 [details]
Patch

Adds the "Add All" option to the context menus for ComplexTypes and Groups. Note that, depending on the state of the type/group when accessed, choosing "Add All" could still cause an error as noted in the description (i.e. if there is an existing sequence, choice or all, the new "all" can only be added as a child, which would be an error).
Comment 2 Valentin Baciu CLA 2007-09-10 17:38:38 EDT 
Keith, please review and commit the patch.
Comment 3 Keith Chong CLA 2007-09-14 17:50:15 EDT 
Fix checked in for WTP 3.0 M2
Comment 4 Keith Chong CLA 2007-10-19 14:12:29 EDT 
Verified in WTP 3.0 integration driver:

http://download.eclipse.org/webtools/committers/drops/R3.0/I-I20071019040808-20071019040808/
Comment 5 David Williams CLA 2008-04-24 00:44:02 EDT 
mass change to add 'contributed' keyword based on bugzilla query, please correct if that's not accurate (by marking patches as obsolete and removing the 'contributed' keyword.