Community
Participate
Working Groups
On Windows, File Explorer performs a union when dragging a folder into a container with an exising folder of the same name. Windows will prompt you to ask you if you want to replace existing files that have the same name as those that you are dragging. However, it does not replace the existing folder with the one being dragged. The 2 are merged. Navigator does NOT do this. It erases the existing folder and uses a prompt similar to the one used by Windows. This is confusing, and can result in accidental deletion. Also, the replace behavior is not as useful as the merge behavior. If I wanted to replace, I could delete the existing folder and then drag the new one. If I want to merge, there is nothing I can currently do. Merging is not possible. Finally, reverting the replace is very cumbersome because Restore from local history has no way of performing a select all.
Which build? This was supposed to have been fixed. It's possible it was fixed for Copy/Paste but not for DnD. Also, Restore from Local should support multi-select.
F2. Multi-select does not work in Restore. Even if it were multi, would SPACE toggle the selection of all?
Please enter a separate PR against Platform-Compare for the multi-select problem.
Copy/Paste and Move from the menu merge. Drag Copy creates a copy of the item. Drag Move does not merge. [Bug 15894] Move folder overwrites destination - original bug, didn't fix drag move.
DnD should reuse CopyFileAndFoldersOperation and CopyProjectOperation. Should have the following behaviour for both Copy/Paste and DnD: - if file copied to same folder (i.e. attempt to overwrite same file), it should prompt to give a new name, with the default being "Copy of ..." - if file copied to a different folder having a file with the same name, should prompt whether to overwrite - when copying or moving folders, merge src and dest, don't overwrite dest
Please post a scenario where moving a folder on top of an existing folder overwrites the folder. If I do this a copy of the moved folder is created instead of replacing the existing one, as if I had done a drag copy. Opened bug 19905 for this. Will fix drag copy to do the same as copy/paste (CopyFilesAndFolderOperation). CopyProject does not apply since projects can't be drag copied.
JDT Package viewer will cause an Overwrite. Knut, not that you've opened a separate bug for "Copy of" being prepended, should we move this to JDT UI? Package viewer is not consistent with Navigator.
I guess it was Packages viewer the whole time, and not Navigator. But at least we found a related Navigator bug <g>.
I think Lynne at some point did reproduce that drag move does replace. We just haven't been able to reproduce this again. Also, I need to make drag copy consistent with copy/paste. Please open a separate JDT PR for making the package viewer consistent with the new Navigator copy/paste and copy/move behavior and assume that drag copy and drag move will at some point behave like the clipboard based operations.
Based on the code in NavigatorDropAdapter it is impossible to overwrite the destination during a drag move operation if it already exists. The could will always fall back to create a "Copy of" the moved resource.
Drag copy now works like clipboard based copy. Note however that clipboard copy/paste does not preset the rename dialog to "Copy of xyz" but just "xyz". Please open a separate PR if the preset should be changed for both operations.
Changes to NavigatorDropAdapter reviewed by Lynne. Released changes.
Not working in M5. If I drag a regular folder into a src folder in the packages view, it replaces the entire contents instead of performing a merge. Test case: +org.eclipse.jdt.ui +src-jdt +org +eclipse .... +patch +org +eclipse ... I dragged the "org" folder from the patch directory into the src-jdt folder. All of JDT's files were replaces with the one .java file in my patch folder.
*** This bug has been marked as a duplicate of 29838 ***
