Bug 193702 - [Manifest][Editors] Show In > is useless
Summary: [Manifest][Editors] Show In > is useless
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Noam Chitayat CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-06-21 08:39 EDT by Wassim Melhem CLA
Modified: 2007-06-22 15:04 EDT (History)
3 users (show)

See Also:
mike.pawlowski: review+
baumanbr: review+


Attachments
Patch for bug 193702. (2.49 KB, patch)
2007-06-21 16:00 EDT, Noam Chitayat CLA
mike.pawlowski: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wassim Melhem CLA 2007-06-21 08:39:00 EDT
3.3 RC4

Bring up the context menu on any of the manifest editor source pages.

You will see a Show In > item.  It never has any applicable views.

By contrast, the Java editor has 3 applicable views.
Comment 1 Brian Bauman CLA 2007-06-21 10:33:28 EDT
Since you are looking at the formatting action on the read only Manifest, can you look at this one too.  Should be in the same area.
Comment 2 Mike Pawlowski CLA 2007-06-21 13:04:38 EDT
The "Show In" menu appears to be dynamically populated.

In my host workbench I see the following entries for the plugin.xml source page:
* Navigator
* History
* Package Explorer

In my runtime workbench I don't see any entries for the plugin.xml source page.

In the Java editor, there is also the "Outline" view.

What should Noam do?


Comment 3 Wassim Melhem CLA 2007-06-21 13:10:04 EDT
Mike, it's not a host vs runtime workbench thing.

It's a perspective thing.

If you are in the PDE perspective, the menu is always empty.
Comment 4 Markus Keller CLA 2007-06-21 13:54:10 EDT
This is one of the Great Unsolved Problems, see e.g. bug 173649 :-(
The only "fix" right now is to enumerate all known views all over the place (in
plugin.xml and in the editors's getAdapter(..)).
Comment 5 Brian Bauman CLA 2007-06-21 13:55:21 EDT
Noam's the man!  He has already dealt with this menu before in the Plug-ins
view (bug 186578) and should have little problem with it :)
Comment 6 Noam Chitayat CLA 2007-06-21 16:00:13 EDT
Created attachment 72080 [details]
Patch for bug 193702.

This problem is actually more widespread: every PDE source page is affected.

With this patch, any source page editor associated with a workspace resource will display "Package Explorer" and "Navigator" as choices in the "Show In >" submenu. PDE resources unavailable in the workspace will not have these two options.

As a nice side-effect, the "Show In" keyboard shortcut (Alt+Shift+W) now works in PDE source pages as well. :)
Comment 7 Brian Bauman CLA 2007-06-21 17:42:20 EDT
Beautiful.  Nice job investigating and fixing other source pages.  Like how you also considered the read-only scenario.  Nice patch!

Mike, if you are satisfied with the patch go ahead and apply it to HEAD.
Comment 8 Mike Pawlowski CLA 2007-06-22 15:03:26 EDT
Comment on attachment 72080 [details]
Patch for bug 193702.

Patch tested well.
Thanks Noam.
Comment 9 Mike Pawlowski CLA 2007-06-22 15:04:33 EDT
Patch released to HEAD.