Bug 193570 - add eclipse.inf to top level directory of jdt.core
Summary: add eclipse.inf to top level directory of jdt.core
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 187396 192983
  Show dependency tree
 
Reported: 2007-06-20 12:47 EDT by Kim Moir CLA
Modified: 2007-06-21 16:39 EDT (History)
2 users (show)

See Also:
Olivier_Thomann: pmc_approved+
Mike_Wilson: pmc_approved+
aniefer: review+
dj.houghton: review+
sonia_dimitrov: review+


Attachments
patch for jdt.core jar in 3.3 stream (365 bytes, patch)
2007-06-20 12:50 EDT, Kim Moir CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kim Moir CLA 2007-06-20 12:47:51 EDT
As described in bug 192983 and in the arch call today, there is a problem with a corrupt signature on one of the classes in the jdt.core jar in the last build toward 3.3.

Verifying org.eclipse.jdt.core_3.3.0.v_768.jar:  STDOUT: jarsigner: java.lang.SecurityException: SHA1 digest error for org/eclipse/jdt/core/dom/InternalASTRewrite.class

Andrew has determined that behaviour is exhibited in packed jars where there are class files at the root of the plugin and nested jars.  We don't know the root cause yet, but to avoid this problem, we are asking the jdt.core team to add an eclipse.inf at the root which will avoid packing nesting jars.  I will attach a patch and request approval for 3.3.  We have already talked to the PMC regarding this issue.
Comment 1 Kim Moir CLA 2007-06-20 12:50:46 EDT
Created attachment 71928 [details]
patch for jdt.core  jar in 3.3 stream
Comment 2 Olivier Thomann CLA 2007-06-20 13:13:24 EDT
I'll wait for all +1 are in to release and update the map file.
Comment 3 Mike Wilson CLA 2007-06-21 08:51:25 EDT
+1.
Comment 4 Olivier Thomann CLA 2007-06-21 09:01:46 EDT
Released for 3.3.
Comment 5 Mike Wilson CLA 2007-06-21 09:30:08 EDT
Olivier's PMC approval above was for my +1 below. 
Comment 6 Kim Moir CLA 2007-06-21 16:39:17 EDT
Verified updating from platform with 1.5 vm to the jdt-feature from build I20070621-1340 update site.