Bug 193418 - [ACC] WSDL Editor - Cannot select design elements with keyboard alone
Summary: [ACC] WSDL Editor - Cannot select design elements with keyboard alone
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: wst.wsdl (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M2   Edit
Assignee: Richard Mah CLA
QA Contact: Craig Salter CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-06-19 18:10 EDT by Joshua Gorner CLA
Modified: 2008-04-24 00:44 EDT (History)
2 users (show)

See Also:


Attachments
Patch (2.73 KB, patch)
2007-06-25 16:59 EDT, Joshua Gorner CLA
bjorn.freeman-benson: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Gorner CLA 2007-06-19 18:10:27 EDT
Steps to reproduce:

1. Open or create a WSDL file and ensure the current edit mode is Design mode.
2. Ensure that no on-screen elements (e.g. service, binding, porttype) within the Design window are presently selected.
3. Attempt to select an element by using the arrow keys.

Expected results: An element (not necessarily any element in particular) is selected (and ergo other elements can be selected with the appropriate arrow keys).

Actual results: Continues to have no element selected.

Hence a user without a mouse would be unable to select/modify any such elements via the Design view (although, of course, one could edit the code manually, or in some cases use Outline or Properties).
Comment 1 Richard Mah CLA 2007-06-21 14:48:43 EDT
Joshua, if you can take a crack at this.

Gabriel, you've handled the ACC (keyboard navigation) in the past.  Could you please give Joshua some quick tips on where to start.  I've targetted the bug to 3.0.
Thanks.
Comment 2 Joshua Gorner CLA 2007-06-21 15:00:13 EDT
As well, selection is lost if one takes a part within an operation and attempts to reorder it. This apparently occurs with both keyboard and mouse, but would be most detrimental to keyboard-only users.
Comment 3 Joshua Gorner CLA 2007-06-25 16:59:42 EDT
Created attachment 72408 [details]
Patch

This patch checks the type of EditPart when an arrow key is pressed in the editor; if it's blank space (e.g. Column or Definition) it goes to the first child, and so on until a "selectable" EditPart is found (alternatively, does nothing if there are no services, bindings, or PortTypes). Normally this means that any arrow key press with no current selection will result in the first service being selected.

The other issue I noted in comment #2 appears to be resolved in the latest build and is not affected by this attachment.
Comment 4 Valentin Baciu CLA 2007-09-10 17:37:49 EDT
Rich, please review the patch and commit and release if all is OK.
Comment 5 Richard Mah CLA 2007-09-15 12:23:27 EDT
Patch has been checked in and will be released soon.
Comment 6 Valentin Baciu CLA 2007-10-02 10:31:33 EDT
This appears to be fixed now. Closing.
Comment 7 David Williams CLA 2008-04-24 00:44:02 EDT
mass change to add 'contributed' keyword based on bugzilla query, please correct if that's not accurate (by marking patches as obsolete and removing the 'contributed' keyword.