Bug 193380 - [Refresh] Deleting Connection Refresh's Entire Remote Systems View
Summary: [Refresh] Deleting Connection Refresh's Entire Remote Systems View
Status: CLOSED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.0.1   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-06-19 14:49 EDT by Kevin Doyle CLA
Modified: 2011-05-25 09:37 EDT (History)
2 users (show)

See Also:


Attachments
Removed refresh() call and added remove(multiSource) (1.43 KB, patch)
2007-07-04 16:16 EDT, Kevin Doyle CLA
mober.at+eclipse: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Doyle CLA 2007-06-19 14:49:27 EDT
If you delete a connection the entire Remote Systems View is refreshed.  All folders expanded on other connections become collapsed!

Steps to Reproduce:
1. Create a 1 or 2 connections.
2. Connect and expand some folders in those connections.
3. Delete your LOCAL connection.
--> All folders expanded are collapsed from the other connections.

We are doing a refresh() in SystemView.RefreshChangedJob.runInUIThread() for the case of EVENT_DELETE_MANY.  What we should be doing is a remove(IHost).

-----------Enter bugs above this line-----------
TM 2.0RC3 Testing
installation : eclipse-SDK-3.3RC4
RSE install  : RSE 2.0 RC3
java.runtime : Sun 1.5.0_11-b03
os.name:     : Windows XP, Service Pack 2
------------------------------------------------
Comment 1 Kevin Doyle CLA 2007-07-04 16:16:12 EDT
Created attachment 73068 [details]
Removed refresh() call and added remove(multiSource)

Deleting a connection would refresh the entire view because the code checks the parentItem and it it's the Tree it refresh's the entire tree.  Instead I added code, so it just makes a remove call.

Legal Message: I, Kevin Doyle, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer, IBM Canada Ltd. to make this
contribution under the EPL.
Comment 2 David McKnight CLA 2007-07-04 16:37:08 EDT
I've committed the patch to cvs.  Thanks.
Comment 3 Kevin Doyle CLA 2007-07-05 13:34:33 EDT
Verified with I20070705-0600.