Bug 192863 - [Eye Candy] [Viewers] add support for comparing plugin.xml file
Summary: [Eye Candy] [Viewers] add support for comparing plugin.xml file
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
: 153873 197671 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-06-15 09:08 EDT by Michael Valenta CLA
Modified: 2007-08-13 10:55 EDT (History)
3 users (show)

See Also:

Attachments
Initial patch (88.81 KB, patch)
2007-06-15 09:15 EDT, Michael Valenta CLA 		no flags Details | Diff
Patch that fixes the image disposed error (230.75 KB, patch)
2007-07-24 09:37 EDT, Michael Valenta CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2007-06-15 09:08:10 EDT 
We should add support for comparing plugin.xml files.
Comment 1 Michael Valenta CLA 2007-06-15 09:15:09 EDT 
Created attachment 71445 [details]
Initial patch

This is an initial cut at this. It is mostly complete but has an issue if changes are made in the editor and saved. This will cause the images that are used in the UI to be disposed.

There are a few other things worth noting:

1) The extentions for the content viewer in PLUGIN and PLUGIN2. The first is just a place holder (see next point) and the second is used to match file segments when the user chooses an entry in the structure view.

2) The extenstion for the structure viewer is PLUGIN. I included this because the schema requires that an extension be provided. We should investigate removing the restriction.

3) I needed to modify the partitioning used by the plugin xml source viewer. It was using the default partition which is dangerous. I think I updated all the necessary places but this should be checked again.
Comment 2 Michael Valenta CLA 2007-07-24 09:37:14 EDT 
Created attachment 74455 [details]
Patch that fixes the image disposed error
Comment 3 Michael Valenta CLA 2007-07-24 09:41:01 EDT 
The patch is ready so I'm moving this to PDE/UI to have a look. This patch uses the same syntax highlighting and outline for compare that the manifest editor uses for plugin.xml files (and, as a bonus, many of the unused XML example classes are removed). The image disposed error mentioned in comment 1 is fixed. Points 1 and 2 in that comment are for information purposes but you may want to look into point 3 to make sure I didn't miss all the references to the default partitioner.
Comment 4 Wassim Melhem CLA 2007-07-24 13:40:35 EDT 
*** Bug 197671 has been marked as a duplicate of this bug. ***
Comment 5 Wassim Melhem CLA 2007-07-24 13:44:55 EDT 
*** Bug 153873 has been marked as a duplicate of this bug. ***
Comment 6 Wassim Melhem CLA 2007-07-25 23:15:08 EDT 
Thanks Michael.  It is so pretty.  

I released the patch with the following modifications:

1. a couple of references to the old partitioning.
2. fixed up the compare/merge font by declaring a font definition.
3. NLS'd some strings.
Comment 7 Wassim Melhem CLA 2007-07-25 23:30:36 EDT 
The compare does not currently work on fragment.xml files.  Opened bug 197905 for that.
Comment 8 Chris Aniszczyk CLA 2007-08-13 10:55:29 EDT 
adding noteworthy keyword