Community
Participate
Working Groups
2.0RC3-200706131923 It seems more natural than a popup dialog from the preference page popping up another dialog over itself.
Craig, what do you think of this for some future version? Any ideas about who should shepherd it if you agree with it?
Makes sense. Our import/export dialog predates the platform's support an we've never found the time exploit that support. AFAIK, Who ever has time to do it is welcome to it. That's my new campaign slogan :-) Nitin, I'll assign to you since you woke the sleeping puppy.
I'll take this one as a bug day project. Good refactoring experience.
Do you want the Advanced button removed entirely from the XML Catalog preferences page, and a new Import and Export options for the XML Catalog to be added to the appopriate entries in the Import and Export dialogs?
Created attachment 74889 [details] mylyn/context/zip Import XML Catalog Wizard. The Import wizard page is showing up but for some reason cannot get the SingleFileViewer to populate the tree. It has to be the way I'm calling the tree population, but unsure exactly why it isn't working. Patch will be following that shows what is included so far.
Created attachment 74890 [details] Initial Cut at Import XML Catalog This implements partial functionality. It adds the Import and Export XML Catalog options to the Import and Export Wizards. The Import XML Catalog page is displayed, however the tree view is not populated.
Created attachment 74925 [details] Partial Implementation of Import/Export Wizard for Catalogs This implements the dialogs for the Import Wizard for the XML Catalog. All that is needed is to add the appropriate finish code to actually import the selected catalog. Question being the user have an option of which area to import it into. Currently I'm planning on dropping it in the User Defined area.
Created attachment 74927 [details] mylyn/context/zip Context of patch.
Because of the UI changes, this will have to wait until we've branched for 3.0 development. Dave, looks promising.
(In reply to comment #4) > Do you want the Advanced button removed entirely from the XML Catalog > preferences page, and a new Import and Export options for the XML Catalog to be > added to the appopriate entries in the Import and Export dialogs? Yes, I'd rather be a definitive place to go within the UI to accomplish a particular task. Shortcuts to that place are fine, such as a Link that opens the right wizard, just so long as it's clear that the function linked to is actually elsewhere.
> Yes, I'd rather be a definitive place to go within the UI to accomplish a > particular task. Shortcuts to that place are fine, such as a Link that opens > the right wizard, just so long as it's clear that the function linked to is > actually elsewhere. Okay, simple enough to do. One thing I am running into on my performFinish is getting the User Defined Catalog to update. Even the Advanced Import version doesn't seem to be updating the User Defined Catalog correctly. I'll upload a patch and some contexts so that I can get some feed back. I'm pretty sure it's something simple, that I'm missing. I can get the file that is selected, and I don't get any errors when saving the catalog, but it doesn't appear in the XML Catalog preferences section. There is another option that is working within the preferences page, that I'll investigate to see how it is adding the user defined catalog entry. Note: Currently there seems to be three different ways to get a catalog added, all using slightly different UI.
Created attachment 74964 [details] mylyn/context/zip Import Page Wizard for XmlCatalog. Includes perform Finish, but is not updating the User Defined Catalog with the values. No exceptions are thrown.
Created attachment 74965 [details] Import Wizard Implemented except Catalog isn't saved For some reason the catalog is not being saved correctly. No errors are shown, and the wizard finishes without problems.
XML Catalog import has been converted to a Wizard, and verified to work. The issue I was having was with an invalid XML Catalog file that I was using to import the file. Unfortunanetly, there was no indication that the file wasn't a valid XML Catalog file, it just didn't import anything. I'll start work on the migration of the Export XML Catalog to a wizard next.
Created attachment 75282 [details] mylyn/context/zip Final Patch context.
Created attachment 75283 [details] Final Patch with full functionality for Import and Export of XML Catalogs via Wizards. This is the the final working patch. 1. Import XML Catalog Wizard - Allows for importing of an existing xmlcatalog file into the user catalog. 2. Export XML Catalog Wizad - Exports all entries from the User Catalog into a file of the users choosing. Location can be either in the existing workspace or outside. 3. Removes the Advanced button from the XML Catalog Preferences page. This patch also fixed minor grammatical errors, and leverages where possible existing Wizards. The Export Wizard leverages the BasicNewFileResourceWizard. Much of the old code int he AdvancedButton class has been migrated into the new classes. This is functionally complete.
David, a cursory glance at the patch looks great with one major problem: the new ExportXMLCatalogWizard and ImportXMLCatalogWizard classes should be coopyright by *you* as the originator, not by IBM. The rest of the copyright text is correct for the EPL license, but let's give you credit everywhere it's due :)
Thanks, Nitin. I'll get the copyrights updated and post a new patch.
Created attachment 75322 [details] Import/Export XML Catalog Wizards - final Corrected copyrights on new files so they are correctly copyrights by STAR.
*** Bug 101951 has been marked as a duplicate of this bug. ***
Opened IPzilla https://dev.eclipse.org/ipzilla/show_bug.cgi?id=1780 (patch is over the magic 250 line count).
Just checking to see if this is still scheduled for M4?
Yep.
Verified with S-3.0M4-20071229165007.
.
adding noteworthy keyword since this sounds like a noteworthy bug. (i'll write something up)
(In reply to comment #16) > 2. Export XML Catalog Wizad - Exports all entries from the User Catalog into a > file of the users choosing. Location can be either in the existing workspace > or outside. While verifying the patch attached to bug 113249, I found that there was still no way to export entries from the catalog to a location outside the workspace.
(In reply to comment #27) > (In reply to comment #16) > > 2. Export XML Catalog Wizad - Exports all entries from the User Catalog into a > > file of the users choosing. Location can be either in the existing workspace > > or outside. > > While verifying the patch attached to bug 113249, I found that there was still > no way to export entries from the catalog to a location outside the workspace. > Yeah, there needs to be a redesign of the wizard screens to allow this to happen.
mass change to add 'contributed' keyword based on bugzilla query, please correct if that's not accurate (by marking patches as obsolete and removing the 'contributed' keyword.
