Bug 192296 - [Schema][Editors] Extension element details section tweaks
Summary: [Schema][Editors] Extension element details section tweaks
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Adam Archer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-06-12 17:50 EDT by Mike Pawlowski CLA
Modified: 2007-07-10 18:51 EDT (History)
1 user (show)

See Also:
mike.pawlowski: review+

Attachments
patch (3.09 KB, patch)
2007-07-10 15:29 EDT, Adam Archer CLA 		mike.pawlowski: review+
Details | Diff
additional patch (1.11 KB, patch)
2007-07-10 18:15 EDT, Adam Archer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Pawlowski CLA 2007-06-12 17:50:54 EDT 
To see extension element details section do the following:

(1) Open any schema containing and "extension" element
(2) Go to "Definition" page
(3) Select "extension" element

Recommend the following in "Element Details" section

* Change name from "Element Details" to "Extension Element Details"
  -> Section fields are already different from fields in non-extension element details section. Should differentiate the two.

* Make "Name" field read-only
  -> Should not allow user to change the "extension" element name to something else
Comment 1 Adam Archer CLA 2007-07-10 15:29:21 EDT 
Created attachment 73467 [details]
patch
Comment 2 Mike Pawlowski CLA 2007-07-10 15:43:13 EDT 
Comment on attachment 73467 [details]
patch

Another good patch Adam.  Thanks.
Comment 3 Mike Pawlowski CLA 2007-07-10 15:45:06 EDT 
Patch applied to HEAD.

Target:  3.4 M1
Comment 4 Adam Archer CLA 2007-07-10 18:15:26 EDT 
Created attachment 73488 [details]
additional patch

I must have uploaded an old version of the patch or something. The listener on the field should be removed as well since it is now read only.

This patch is to be applied to the code now in HEAD (i.e. on top of the old patch). It removes the listener to the fName field.
Comment 5 Mike Pawlowski CLA 2007-07-10 18:51:33 EDT 
Thanks Adam.  I should have caught that.  Patch applied to HEAD.