Bug 192275 - [Schema][Editors] Should not be able to specify an element reference to the "extension" element
Summary: [Schema][Editors] Should not be able to specify an element reference to the "...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Adam Archer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-06-12 15:52 EDT by Mike Pawlowski CLA
Modified: 2007-07-10 13:01 EDT (History)
1 user (show)

See Also:
mike.pawlowski: review+

Attachments
patch (1.50 KB, patch)
2007-07-10 12:11 EDT, Adam Archer CLA 		mike.pawlowski: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Pawlowski CLA 2007-06-12 15:52:41 EDT 
Definition Page -> Extension Point Elements Section

Steps To Reproduce:

(1) Open any schema containing an "extension" element node
(2) Select any compositor
(3) Select "New > Reference > extension"
    -> Bug: "extension" element is the root node of the contributed grammar,
       it should never be a child element of another element

Expected Behaviour:

The "extension" element should never be offered as a valid child element reference.
Comment 1 Adam Archer CLA 2007-07-10 12:11:13 EDT 
Created attachment 73438 [details]
patch

Checks if the elements are instances of SchemaRootElement before adding actions to the submenu.
Comment 2 Mike Pawlowski CLA 2007-07-10 13:00:29 EDT 
Comment on attachment 73438 [details]
patch

Nice clean patch Adam, Thanks.
Comment 3 Mike Pawlowski CLA 2007-07-10 13:01:36 EDT 
Patch released to HEAD.

Target:  3.4 M1