Bug 192267 - [Schema][Editors] Description section too prominent
Summary: [Schema][Editors] Description section too prominent
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Adam Archer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 196232 (view as bug list)
Depends on:
Blocks: 196232
  Show dependency tree
 
Reported: 2007-06-12 15:10 EDT by Mike Pawlowski CLA
Modified: 2007-07-18 19:17 EDT (History)
1 user (show)

See Also:
mike.pawlowski: review+

Attachments
patch (100.17 KB, patch)
2007-07-18 14:05 EDT, Adam Archer CLA 		mike.pawlowski: review-
Details | Diff
patch (100.22 KB, patch)
2007-07-18 14:46 EDT, Adam Archer CLA 		no flags Details | Diff
patch... for real this time (89.21 KB, patch)
2007-07-18 15:33 EDT, Adam Archer CLA 		mike.pawlowski: review+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Pawlowski CLA 2007-06-12 15:10:22 EDT 
Definition Page -> Description Section

The Description section is usually only used for element descriptions and takes up valuable real estate.

Remove the Description section as a global horizontal section and add it as a vertical local section under each of the <element-node-type> Details sections as follows:

* Element Details Section
  -> Add Description section for both 'normal' elements and "extension" elements

* Attribute Details Section
  -> Add Description section

* Compositor Details Section
  -> Do NOT add Description section

* Element Reference Details Section
  -> Add Description section; but, field contents should always be in sync with the contents specified in referenced element's Description section

Also, the font size used in the description sections needs to be reduced to contain long descriptions and any sample mark-up
Comment 1 Mike Pawlowski CLA 2007-07-10 10:27:27 EDT 
From an educational standpoint, this is an interesting one; but, it may be a lot of work.  Save this one for last.
Comment 2 Mike Pawlowski CLA 2007-07-11 15:39:06 EDT 
RE:  Comment #0

Requirements Update:

* Element Reference Details Section
  -> Do NOT add Description section

Modifying a global element description using a local element reference is confusing from a schema annotation perspective.
Comment 3 Adam Archer CLA 2007-07-18 14:05:13 EDT 
Created attachment 74080 [details]
patch

This one's a doozy.
Comment 4 Adam Archer CLA 2007-07-18 14:08:30 EDT 
*** Bug 196232 has been marked as a duplicate of this bug. ***
Comment 5 Mike Pawlowski CLA 2007-07-18 14:22:09 EDT 
Comment on attachment 74080 [details]
patch

The UI field arrangement is amazing; however, the editor opens dirty (and gets dirtied on schema object selections)
Comment 6 Adam Archer CLA 2007-07-18 14:46:49 EDT 
Created attachment 74081 [details]
patch

I was missing a blockListeners() check.  :)
Comment 7 Adam Archer CLA 2007-07-18 15:33:01 EDT 
Created attachment 74085 [details]
patch... for real this time

There were a couple more problems with undo/redo and field assist.
Comment 8 Mike Pawlowski CLA 2007-07-18 19:17:18 EDT 
Comment on attachment 74085 [details]
patch... for real this time

Excellent work Adam.  Clean UI separation of different attribute types. Tested well.  Thanks.
Comment 9 Mike Pawlowski CLA 2007-07-18 19:17:56 EDT 
Patch released to HEAD.

Target:  3.4 M1