Bug 192259 - [Schema][Editors] Add "Remove", "New Choice", "New Sequence" buttons
Summary: [Schema][Editors] Add "Remove", "New Choice", "New Sequence" buttons
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Adam Archer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-06-12 14:32 EDT by Mike Pawlowski CLA
Modified: 2007-07-11 16:17 EDT (History)
1 user (show)

See Also:
mike.pawlowski: review+

Attachments
patch (6.13 KB, patch)
2007-07-11 11:32 EDT, Adam Archer CLA 		mike.pawlowski: review-
Details | Diff
fixed patch (4.22 KB, patch)
2007-07-11 14:23 EDT, Adam Archer CLA 		no flags Details | Diff
fixed fixed patch (6.18 KB, patch)
2007-07-11 15:16 EDT, Adam Archer CLA 		mike.pawlowski: review+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Pawlowski CLA 2007-06-12 14:32:07 EDT 
Definition Page -> Extension Point Elements Section

* Add button "Remove"
  -> Functionality and enablement same as pressing delete key

* Add button "Add Sequence"
  -> Functionality and enablement same as right-clicking and selecting 
     "New > Compositor > Sequence"

* Add button "Add Choice"
  -> Functionality and enablement same as right-clicking and selecting 
     "New > Compositor > Choice"
Comment 1 Adam Archer CLA 2007-07-11 11:32:29 EDT 
Created attachment 73556 [details]
patch
Comment 2 Mike Pawlowski CLA 2007-07-11 13:47:02 EDT 
Comment on attachment 73556 [details]
patch

Everything looks good and tested well.  However, there is one minor issue.  See next comment for details.
Comment 3 Mike Pawlowski CLA 2007-07-11 13:51:56 EDT 
Minor Problem:

* Select an element reference
  -> BUG:  The "New Choice" and "New Sequence" buttons are enabled and do
     nothing when clicked
  -> Both buttons should be disabled in this case
Comment 4 Adam Archer CLA 2007-07-11 14:23:49 EDT 
Created attachment 73577 [details]
fixed patch
Comment 5 Adam Archer CLA 2007-07-11 15:16:36 EDT 
Created attachment 73585 [details]
fixed fixed patch

I forgot the externalized strings in the previous patch.
Comment 6 Mike Pawlowski CLA 2007-07-11 16:16:06 EDT 
Comment on attachment 73585 [details]
fixed fixed patch

Looks great Adam.  Thanks
Comment 7 Mike Pawlowski CLA 2007-07-11 16:17:03 EDT 
Patch released to HEAD.

Target:  3.4 M1