Bug 191976 - [Cleanup] Use ScaledGraphics class from Draw2D
Summary: [Cleanup] Use ScaledGraphics class from Draw2D
Status: NEW
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal
Target Milestone: 2.1   Edit
Assignee: Anthony Hunter CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 242376 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-06-11 10:53 EDT by Dmitry Stadnik CLA
Modified: 2010-11-22 11:27 EST (History)
0 users

See Also:

Attachments
a proposition of ScaledGraphics class (6.82 KB, application/octet-stream)
2010-11-19 12:50 EST, Aurelien Pupier CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Stadnik CLA 2007-06-11 10:53:07 EDT 
GMF runtime has it's own version of ScaledGraphics class that duplicates ScaledGraphics class functionality in Draw2D component.
Comment 1 Anthony Hunter CLA 2007-06-19 14:54:46 EDT 
Agreed that ScaledGraphics should be extending org.eclipse.draw2d.ScaledGraphics

I did a compare with Draw2d and we can likely handle this issue as a generic cleanup issue.
Comment 2 Eclipse Webmaster CLA 2010-07-19 12:29:27 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug
Comment 3 Aurelien Pupier CLA 2010-11-19 12:50:40 EST 
Created attachment 183490 [details]
a proposition of ScaledGraphics class

I take a look at it.

We need to request on GEF:
attributes become protected or to have a proctected gettter method:
- graphics
- zoom

make protected methods:
- setScale(double value)
- zoomRect(int x, int y, int w, int h)

make a status on the Font issue (https://bugs.eclipse.org/bugs/show_bug.cgi?id=111454)
- use Font registry in GEF
- keep using the default Font cache used by GEF
- ask to have FOntKey class and key attribute protected
Comment 4 Aurelien Pupier CLA 2010-11-22 11:27:25 EST 
*** Bug 242376 has been marked as a duplicate of this bug. ***