Bug 191870 - we should auto-detect "prebuilt" in map files, and not condition those
Summary: we should auto-detect "prebuilt" in map files, and not condition those
Status: NEW
Alias: None
Product: Orbit
Classification: Tools
Component: releng (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-10 20:51 EDT by David Williams CLA
Modified: 2016-08-11 15:22 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2007-06-10 20:51:03 EDT
bug 178723 was fixed so our infrastructure won't condition pre-built jars
but the list of such jars is currently "hard coded" in the buildUtilities script. 

We should compute that list from the map files where bundles are marked "pre-built".
Comment 1 David Williams CLA 2007-06-15 23:24:17 EDT
Reminder: if/when we use the "prebuilt=true" tag to effect the build, we should be sure to update the 'mapfilegenerator' utility so that "prebuilt=true" is added to the HTTP version of the map files, since downstream builders will likely need to get this same information (from somewhere). 

Comment 2 David Williams CLA 2011-04-20 12:28:55 EDT
As I observed in bug 343416, while investigating another issue, our current script is not quite as "dumb" as I first thought. While it does use patterns such as "com.jcraft.jsch*" to (help) find pre-built bundles, we probably would not have to. The script also uses Ant's "fileset" task to retrieve the jar files that were downloaded from cvs, "as is". We could (probably) just assume any "jar" file that was obtained from cvs and put in ${builddirectory}/plugins as a jar file (and not as an exploded directory) was in fact a pre-built bundle and use that assumption to form our exclude list. 

I still think best to make use the "pre-built" flag in map file, some day, in future improvements, but wanted to document what I learned from bug 343416, so I wouldn't forget. Its kind of cool, actually, since it allowed us to have some general patterns, such as "com.jcraft.jsch*" but then some versions of that bundle were pre-built, and some were not. Currently, all of the "com.jcraft.jsch* bundles are not pre-built, as the older, pre-built ones were removed from active builds and as intended, none are excluded from conditioning.
Comment 3 David Williams CLA 2016-08-11 15:22:45 EDT
Doing a mass "reset to default assignee" of 21 bugs to help make clear it will (very likely) not be me working on things I had previously planned to work on. I hope this will help prevent the bugs from "getting lost" in other people's queries. Feel free to "take" a bug if appropriate.