Bug 191545 - bin.excludes does not propery update
Summary: bin.excludes does not propery update
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2.2   Edit
Hardware: All Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Brock Janiczak CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2007-06-07 14:42 EDT by C. Lamont Gilbert CLA
Modified: 2007-08-05 16:04 EDT (History)
3 users (show)

See Also:

Attachments
patch to org.eclipse.pde.ui (1.72 KB, patch)
2007-08-04 20:24 EDT, Brock Janiczak CLA 		no flags Details | Diff
mylyn/context/zip (999 bytes, application/octet-stream)
2007-08-05 16:04 EDT, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description C. Lamont Gilbert CLA 2007-06-07 14:42:32 EDT 
With a plugin project the bin.excludes does not update when a jar file is deleted from the project.  With bin.includes, the manifest gets updated with a yellow warning triangle.  But this does not happen with bin.excludes.
Comment 1 Brian Bauman CLA 2007-06-14 11:21:41 EDT 
Why would you want a warning if you are trying to exclude something which isn't there?  If you are trying to exclude a file/folder and it isn't there to be included, aren't you achieving your desired result?
Comment 2 Wassim Melhem CLA 2007-06-14 11:24:30 EDT 
Brian, it makes sense to have this kind of check if, say, there is a typo in the folder name that you are trying to exclude.
Comment 3 Brian Bauman CLA 2007-06-14 11:35:26 EDT 
Should be easy to add this to our builder.
Comment 4 Brock Janiczak CLA 2007-08-04 20:24:11 EDT 
Created attachment 75394 [details]
patch to org.eclipse.pde.ui

Adds resource checking to the bin and src excludes.  It re-uses the existing validateIncludes method, which may be wrong.
Comment 5 Chris Aniszczyk CLA 2007-08-05 15:33:21 EDT 
adding contributed keyword, assigning to Brock.
Comment 6 Chris Aniszczyk CLA 2007-08-05 16:04:07 EDT 
looks clean Brock, thanks for the patch. It's as simple as that :)

Applied to HEAD.
Comment 7 Chris Aniszczyk CLA 2007-08-05 16:04:14 EDT 
Created attachment 75401 [details]
mylyn/context/zip