Bug 191370 - [dstore] Supertransfer zip not deleted when cancelling copy
Summary: [dstore] Supertransfer zip not deleted when cancelling copy
Status: CLOSED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M4   Edit
Assignee: Xuan Chen CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-06 17:14 EDT by Kevin Doyle CLA
Modified: 2009-06-17 13:22 EDT (History)
3 users (show)

See Also:

Attachments
fix for this problem (10.62 KB, patch)
2007-12-30 21:59 EST, Xuan Chen CLA 		no flags Details | Diff
fix for this problem (missed one file in last patch) (12.40 KB, patch)
2007-12-30 22:01 EST, Xuan Chen CLA 		no flags Details | Diff
fix for this problem (7.71 KB, patch)
2008-01-22 22:56 EST, Xuan Chen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Doyle CLA 2007-06-06 17:14:39 EDT 
If you copy and paste a folder from one dstore connection to another dstore connection and cancel it while it is transfering the supertransferxxxxx.zip is not deleted.

-----------Enter bugs above this line-----------
TM 2.0RC2 Testing
installation : eclipse-SDK-3.3M7
RSE install  : RSE 2.0 RC2
java.runtime : Sun 1.5.0_11-b03
os.name:     : Windows XP, Service Pack 2
------------------------------------------------
Comment 1 Martin Oberhuber CLA 2007-06-06 17:36:45 EDT 
I do not see this as a big issue, tentatively assigning 2.0.1
Comment 2 Martin Oberhuber CLA 2007-10-01 07:57:16 EDT 
Bulk update target milestone 2.0.1 -> 3.0
Comment 3 Xuan Chen CLA 2007-12-30 21:59:54 EST 
Created attachment 85946 [details]
fix for this problem

I also used this bug to fix some problem with cancelation of copy between different connections.
Comment 4 Xuan Chen CLA 2007-12-30 22:01:55 EST 
Created attachment 85947 [details]
fix for this problem (missed one file in last patch)
Comment 5 Xuan Chen CLA 2007-12-30 22:04:26 EST 
Committed the fixes into cvs.
Comment 6 Kevin Doyle CLA 2008-01-18 13:49:25 EST 
Reopening as the supertransfer zip still exists if you cancel while it is populating the archive.  It's also logging an exception RSEG1067E, which is Operation Canceled.

Steps to Reproduce:
1. Connect to 2 dstore connections.
2. Copy a large folder from one connection.
3. Paste that folder somewhere on the other connection.
4. While it is "Populating temp archive" click Cancel.
5. Go back to the connection that you copied the large folder from and do a refresh on the parent of the folder you copied.  Supertransfer zip is still there.
Comment 7 Xuan Chen CLA 2008-01-22 22:56:08 EST 
Created attachment 87596 [details]
fix for this problem

I updated the fix for the following:

In UniversalFileTransferUtility#compressedDownloadToWorkspace(), I will catch SystemMessageException after the following call:
sourceFS.copy().
In the catch statement, if monitor is canceled, we need to delete temporary archive file.
There is also some problem with cancel when copying a folder to an empty zip file.  I also fix it in the SystemZipHandler and SystemTarHandler.
Comment 8 Xuan Chen CLA 2008-01-22 22:58:28 EST 
I've checked in the fix to cvs.

To verify, please make sure you update the server code in both connection.
Comment 9 Xuan Chen CLA 2009-06-17 13:22:59 EDT 
Close since it is fixed.