Bug 191176 - JavaProject#getOption optimizations
Summary: JavaProject#getOption optimizations
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.6 M1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-06 03:20 EDT by Maxime Daniel CLA
Modified: 2009-08-04 07:23 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Daniel CLA 2007-06-06 03:20:36 EDT 
Source based, v_770.

The current code for JavaProject#getOption could be optimized along the following:
- the propertyName local variable is a mere rename of the optionName parameter; use the parameter instead (with or without renaming it);
- the code should be written in a way that warranties that JavaCore.getOption(propertyName) only gets called if strictly needed.
Comment 1 Olivier Thomann CLA 2009-06-25 15:32:10 EDT 
The local variable can indeed be removed.
Comment 2 Olivier Thomann CLA 2009-07-28 10:13:51 EDT 
Released for 3.6M1.
Variable is removed. Code verification is required.
Comment 3 Jay Arthanareeswaran CLA 2009-08-04 04:40:12 EDT 
Verified for 3.6M1 by code inspection