Bug 191111 - Axis2: Axis2 preference selection always saved and cannot be canceled
Summary: Axis2: Axis2 preference selection always saved and cannot be canceled
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: jst.ws (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0   Edit
Assignee: Zina Mostafia CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-06-05 16:05 EDT by Kathy Chan CLA
Modified: 2008-04-24 00:44 EDT (History)
3 users (show)

See Also:


Attachments
Patch to delay saving values in the persistent context till Apply or OK (31.70 KB, patch)
2007-12-05 13:38 EST, Zina Mostafia CLA
bjorn.freeman-benson: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kathy Chan CLA 2007-06-05 16:05:37 EDT
Driver:  WTP 2.0 200706050057 driver

In the Axis2 runtime preference page, the Axis2 runtime location is saved once the user enters or browses for the location.  Even if the user then decided to hit Cancel to not save their selection, they are not able to do so.  After the user enters or browse for the location, validation should be done to make sure that it's a valid Axis2 location.  However, it should not be saved to the preference store until the user actually hits OK.
Comment 1 Kathy Chan CLA 2007-10-31 13:09:03 EDT
Actually, this applies to the Axis2 Preference page as well. The values of the preference should only be stored when the user click OK, but not if they click Cancel.
Comment 2 Zina Mostafia CLA 2007-12-05 13:38:20 EST
Created attachment 84556 [details]
Patch to delay saving values in the persistent context till Apply or OK

Patch to delay storing information entered by the user till user selects OK, or Apply.
If user makes any changes then selects Cancel, no information would be persisted, and settings would be untouched.
Comment 3 Kathy Chan CLA 2007-12-05 22:47:13 EST
Patch reviewed and tested.  I found problem with the presistence of the sync and async button and made the following change to the patch:

  context.setAsync(asyncOnlyRadioButton.getSelection());
  context.setSync(syncOnlyRadioButton.getSelection());

I've committed the patch and released it to HEAD as v200712060346.
Comment 4 Lahiru Sandakith CLA 2007-12-05 23:05:54 EST
I had a look at the patch and its seems to be resolving the problem except that the diff of the patch is not that clear. I am seeing a total removal of the file content and again total addition of most of the same content. This seems to be a bit problem when identifying what actually being done, as I see it. 
Other than that the issue resolved and +1 for the path
Thanks 
Lahiru
Comment 5 Kathy Chan CLA 2007-12-07 10:28:13 EST
Verified on WTP 3.0 12/06 driver.
Comment 6 David Williams CLA 2008-04-24 00:44:36 EDT
mass change to add 'contributed' keyword based on bugzilla query, please correct if that's not accurate (by marking patches as obsolete and removing the 'contributed' keyword.