Bug 191040 - [Widget] Guard addListener/removeListener with checkWidget
Summary: [Widget] Guard addListener/removeListener with checkWidget
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.0   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 1.3 M5   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2007-06-05 10:30 EDT by Rüdiger Herrmann CLA
Modified: 2010-01-28 14:25 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rüdiger Herrmann CLA 2007-06-05 10:30:28 EDT 
Just a reminder.
The various methods to add and remove typed listeners should be guarded with a call to checkWidget() as in SWT.
Comment 1 Ralf Sternberg CLA 2009-02-13 05:02:17 EST 
In addtion to this, the missing null argument checks should also be added:

if( listener == null ) {
  error( SWT.ERROR_NULL_ARGUMENT );
}
Comment 2 Benjamin Muskalla CLA 2009-02-13 05:11:31 EST 
See bug 243874
Comment 3 Ivan Furnadjiev CLA 2009-12-18 05:10:52 EST 
I think that this if fixed. Rüdiger, any additional work here?
Comment 4 Rüdiger Herrmann CLA 2009-12-18 07:16:01 EST 
(In reply to comment #3)
> I think that this if fixed. Rüdiger, any additional work here?
There are stiil some ungarded add/remove*Listener methods. E.g. Control#addControlListener
Comment 5 Rüdiger Herrmann CLA 2010-01-28 14:25:40 EST 
Chagnes are in CVS HEAD