Community
Participate
Working Groups
Allow to customize fonts and colors for all messages views. They should be editable from General / Appearance / Colors and Fonts and configuration.
Setting bugday and target milestone.
Created attachment 77315 [details] initial patch Hello, this initial patch moves all colors previously hardcoded in org.eclipse.ecf.presence.ui.chatroom.MessageRenderer to org.eclipse.ui.themes extension point and makes them available for customization in Window -> Preferences -> General -> Appearance -> Fonts and Colors The patch has only colors, fonts need to be added. but please assign to me for bugday. All message views will hopefully use MessageRenderer after bug 183027 is fixed.
Thanks Jacek. It's already assigned to you for upcoming bugday. I won't be able to apply and check the patch before 8/31/2007 bugday, so (zx) if you can/want to check it out and in please do. Otherwise, I will get to it after 8/31/2007.
Hi Jacek, I have tested this against IRC's nick recognition capability and it does work. However, changing the colours in the preference page does not update existing StyleRanges.
Thanks Remy, I think that changes are applied after next message view is created, i'll check what it. I am just cleaning up a bit the patch, and i think typical user needs to change: 1. background color 2. received messages font/color 3. sent messages font/color 4. received messages that should be highlighted font/color 5. system messages font/color
Created attachment 77478 [details] more fun this patch brings more fun - fonts. and fixes what Remy pointed out. Sorry to say, but again it's unfinished - I have to leave office now - but there are few more things to do, like background color.
(In reply to comment #6) > this patch brings more fun - fonts. > and fixes what Remy pointed out. I'm still getting no updates. The scenario I was describing in comment #4 is as follows: -login and join a channel -have someone say your name, the text shows up as red (the default) -go to preferences -change highlighting colour from red to blue -click apply, move the dialog, the text is still red -click ok, the text is still red The change does get picked up if I disconnect and reconnect though, yes. > Sorry to say, but again it's unfinished - I have to leave office now - but > there are few more things to do, like background color. You weren't kidding about this one. I was shocked to see the date and originator "prefix" of the image show up as black highlighting since the default background colour is black. ;)
Oh I see, unfortunately changes will be applied to newly added text only. It's impossible to update chat history, as messages are not stored anywhere, but simply thrown to SWT StyledText. Maybe it would be good to have some model of history, also for later browsing. Ah it's already reported in bug 177014 and 177020, but does it work now?
Created attachment 77530 [details] colors and fonts Take a look at this. Colors and fonts work quite nice now. I've added /me option to be configurable too.
(In reply to comment #8) > Oh I see, unfortunately changes will be applied to newly added text only. It's > impossible to update chat history, as messages are not stored anywhere, but > simply thrown to SWT StyledText. > > Maybe it would be good to have some model of history, also for later browsing. > Ah it's already reported in bug 177014 and 177020, but does it work now? > We have a history API/model, but it's not been implemented yet by any presence provider. Danila Ermakov had offered at one point to provide an implementation, but we haven't seen it yet.
(In reply to comment #8) > Oh I see, unfortunately changes will be applied to newly added text only. It's > impossible to update chat history, as messages are not stored anywhere, but > simply thrown to SWT StyledText. I don't think accessing the history is the right way to resolve this issue. At any rate, I feel that we can defer this minor nuance to bug 183027. (In reply to comment #9) > Created an attachment (id=77530) [details] > colors and fonts > > Take a look at this. Colors and fonts work quite nice now. I've added /me > option to be configurable too. Committed to CVS HEAD. Thanks for the patch, Jacek!
sorry I forgot this is still NEW. I am used to the rule that committers mark as fixed
(In reply to comment #12) > sorry I forgot this is still NEW. I am used to the rule that committers mark as > fixed It is good that you are used to the rule because it isn't fixed. ;) The 'Messages' view currently does not leverage this capability. Reopening.
No resources available for this enhancement. If resources become available, please feel free to reopen.
