Bug 190842 - do not instanciate a SourceMapper when no source attached
Summary: do not instanciate a SourceMapper when no source attached
Status: VERIFIED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M1   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2007-06-04 12:35 EDT by Eric Jodet CLA
Modified: 2008-08-06 14:38 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Jodet CLA 2007-06-04 12:35:05 EDT 
Version: 3.3.0
Build id: I20070601-1539

see bug 190094 for the context.
see also bug 190840

Test scenario:
- have a type that inherits a class located in a big JAR
- open this type in the Java editor, press Crtl+O twice to show inherited
members

in PackageFragmentRoot#getSourceMapper():
if (sourcePath == null)
	mapper = createSourceMapper(getPath(), rootPath); // attach root to itself
else
	mapper = createSourceMapper(sourcePath, rootPath);

we create a source mapper even if no source available.

If we know that this resource has no source in it, then we should avoid creating a SourceMapper, to prevent further reading of corresponding zip file.
Comment 1 Jerome Lanneluc CLA 2007-06-20 10:20:57 EDT 
Performance work
Comment 2 Jerome Lanneluc CLA 2008-05-07 07:53:17 EDT 
Deferring post 3.4
Comment 3 Jerome Lanneluc CLA 2008-06-10 09:30:32 EDT 
Actually to know that the jar doesn't contain any source, we need a source mapper. And we need to read at least once the jar to know this. No further action planned.
Comment 4 Kent Johnson CLA 2008-08-06 14:38:54 EDT 
Verified for 3.5M1 using I20080805-1307