Community
Participate
Working Groups
the logic in first line of getSeparator() is not correct, since the purpose of this function is to get what was the character need to be inserted between parent and child. if (parentPath == null || parentPath.length() < 2) return "/"; //$NON-NLS-1$ In the case of parent is "/", it returns "/", which is not a correct result according to the purpose of this function. This function is called by the following method in DStoreFileService: DStoreFileService copy(String, String, String, String, IProgressMonitor) copyBatch(String[], String[], String, IProgressMonitor) createFile(String, String, IProgressMonitor) createFolder(String, String, IProgressMonitor) delete(String, String, IProgressMonitor) deleteBatch(String[], String[], IProgressMonitor) download(String, String, File, boolean, String, IProgressMonitor) getFile(String, String, IProgressMonitor) getInputStream(String, String, boolean, IProgressMonitor) getOutputStream(String, String, boolean, IProgressMonitor) rename(String, String, String, IHostFile, IProgressMonitor) rename(String, String, String, IProgressMonitor) setLastModified(String, String, long, IProgressMonitor) setReadOnly(String, String, boolean, IProgressMonitor) upload(File, String, String, boolean, String, String, IProgressMonitor) upload(InputStream, String, String, boolean, String, IProgressMonitor)
I think this is a number of occurrences that's manageable for manual review. Looks like each of these occurrences could potentially create an incorrect absoluteName like //newFile after a copy or rename operation, instead of /newFile. Since absoluteNames are important, we should try and get it right.
Created attachment 70065 [details] Deal with the case where parentPath is "/" in DStoreFileService#getSeparator() Legal Message: I, Xuan Chen, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer, IBM Canada Ltd. to make this contribution under the EPL.
Created attachment 73275 [details] update the patch since file has been changed in Patch needs to be updated since its file has been changed. Legal Message: I, Xuan Chen, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer, IBM Canada Ltd. to make this contribution under the EPL.
Created attachment 73689 [details] Update the patch since the source file been changed in between. Please review this change. Thanks. Legal Message: I, Xuan Chen, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer, IBM Canada Ltd. to make this contribution under the EPL.
Bulk update target milestone 2.0.1 -> 3.0
I've committed the fix into cvs.
This is fixed.
Comment on attachment 73689 [details] Update the patch since the source file been changed in between. Xuan became committer on 19-Jul-2007, so technically the contribution needs to be iplog+ since it was made before being committer: http://dev.eclipse.org/mhonarc/lists/dsdp-tm-dev/msg01376.html
