Community
Participate
Working Groups
build 3.3RC3 1) Enable Folding (Preferences>Java>Editor>Folding) 2) Open org.eclipse.jdt.core.tests.compiler.regression.GenericTypeTest 3) Format this file The source is formatted after 40sec If i disable Folding and do the same test case then the source is formatted after 8sec Folding seems to be very costly in this test case. Perhaps performance of Folding could be improved.
- How big is the file? I don't have the JDT Core tests loaded. - Once it is formatted, how long does disable and then enable folding take? Also, can you check whether this is a regression compared to 3.2? Thanks!
I noticed the problem when i verified bug 189456. GenericTypeTest is a very big file: - 38000 line of code - 1200 methods Once it is formatted disable and enable Folding took around 1sec. It doesn't seem to be a regression. In 3.2.2 it took 100sec when Folding is enabled and 70 sec when disabled.
I will at least fix the difference between projection on and off. This is something we can deal with.
Created attachment 105292 [details] Fix This prevents the projection viewer and semantic highlighting presenter from updating while formatting large documents. Now time is mainly spent in formatter ;-)
Fixed in HEAD. Available in builds > N20080730-2000.
I have to reopen this because every quick fix and every save with enabled clean ups now runs through that code and this leads to unwanted expansion of folded items. We have to defer the fix until bug 249511 is fixed.
Created attachment 114200 [details] Updated Fix
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
