Bug 190805 - [performance][dstore] Right-click > Disconnect on a dstore connection is slow and spawns many Jobs
Summary: [performance][dstore] Right-click > Disconnect on a dstore connection is slow...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.1 M7   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2007-06-04 09:39 EDT by Martin Oberhuber CLA
Modified: 2009-03-25 14:58 EDT (History)
0 users

See Also:

Attachments
patch for better handling of decorating (13.61 KB, patch)
2009-03-25 14:53 EDT, David McKnight CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-06-04 09:39:06 EDT 
Connect to a dstore-UNIX connection, expand some folders.
With the Eclipse Progress View open, select the host node and choose right-click > disconnect. At least 20 Jobs are spawned on disconnect.

-----------Enter bugs above this line-----------
TM 2.0M7 Testing
installation : eclipse-platform-3.3M7 (I20070503-1400), cdt-4.0M7, emf-2.3M7
RSE install  : workspace HEAD
java.runtime : Sun 1.6.0_01-b06
os.name:     : Windows XP 5.1, Service Pack 1
------------------------------------------------
systemtype   : Windows-local, Dstore-win, Dstore-linux
targetos     : Red Hat Enterprise Linux WS release 4 (Nahant Update 3)
targetuname  : Linux parser 2.6.9-34.EL #1 i686 athlon i386 GNU/Linux
targetvm     : Sun Java HotSpot(TM) Client VM (build 1.4.2_12-b03, mixed mode)
------------------------------------------------
Comment 1 David McKnight CLA 2009-03-25 14:53:07 EDT 
Created attachment 129878 [details]
patch for better handling of decorating

This patch involves a few things:
1) a new RemoteFilePropertyChangeListener is needed after a DataStore is disconnected - otherwise we aren't listening to domain events anymore
2) SystemView supports an array of source objects when EVENT_ICON_CHANGE is fired.  This helps reduce the number of events that need to be fired here.
3) The RemoteFilePropertyChangeListener is simplied and makes use of the EVENT_ICON_CHANGE with an array instead of firing multiple events.
Comment 2 David McKnight CLA 2009-03-25 14:58:46 EDT 
I've committed the changes to cvs.