Community
Participate
Working Groups
3.3 RC3 The target editor's content page has two tabs, Plug-ins, Features. Each has the same 5 buttons. The last two buttons, Add Working Set and Add Required Plugins though only apply to the Plug-ins tab. They are grayed/disabled in the Features tab, but this is actually misleading because there is no way to enable them in that tab. Instead, on the Features page the last two buttons should be removed. The layout suggests that the set of buttons are part of the tab area, not part of the editor page, and thus one would expect different controls for different tabs. This is how it works for example in the Product editor's Launching page for the program launcher section: picking solaris vs. win32 yields different controls/settings.
Makes sense. Should not be hard to do, but due to timing we will have to fix post 3.3.
I have a fix for this, but at present it's only for a standard Europa (3.3.0) install. I'm currently downloading the latest integration build (I20071023-0800) and once I've created a patch from that, I'll attach here.
Created attachment 81033 [details] Patch for R3.4
Created attachment 81034 [details] Patch for R3.3
I have attached patches for both R3.4 and R3.3. The R3.3 patch was created and tested against the latest on the R3_3_maintenance branch. The R3.4 patch was created and tested against the I20071023-0800 integration build, but has subsequently been successfully tested against the HEAD - as of about 10 mins ago ;-) For info, during testing I uncovered an issue with these buttons being hidden; I've raised a separate bug for this since it exists in the base I20071023-0800 build (defect 207266). The fix merely adds the capability for the relevant buttons to be hidden when the plug-in tab is not shown. It's a little unfortunate that the relevant method has been renamed between 3.3 and 3.4 from updateButtons() to updateEnablement() - since now I've added the behaviour to update the 'visibility' as well as the 'enablement'. That said, I guess we could consider that a hidden button is a very disabled button ? ;-) Either way, hopefully this patch is useful for you.
Thanks for the patches!
Perfect! Didn't change even one space (other than adding your name to the copyrights). Thanks Les, good job!
verified on I20071211-0010
