Bug 190371 - TVT33:TCT478: ar: Arabic titles need to be right aligned
Summary: TVT33:TCT478: ar: Arabic titles need to be right aligned
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: wst.ws (show other bugs)
Version: 2.0   Edit
Hardware: PC Linux-GTK
: P3 minor (vote)
Target Milestone: 3.0 RC1   Edit
Assignee: Andrew Mak CLA
QA Contact: Kathy Chan CLA
URL: 478
Whiteboard: PMC_APPROVED
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-05-31 18:18 EDT by CDE Administration CLA
Modified: 2008-06-06 10:11 EDT (History)
4 users (show)

See Also:
kathy: pmc_approved? (david_williams)
kathy: pmc_approved? (raghunathan.srinivasan)
kathy: pmc_approved? (naci.dai)
kathy: pmc_approved? (deboer)
neil.hauge: pmc_approved+
kathy: pmc_approved? (kaloyan)

Attachments
11.002240.jpg (132.15 KB, image/jpeg)
2007-05-31 18:18 EDT, CDE Administration CLA 		no flags Details
patch (13.75 KB, patch)
2008-05-06 14:16 EDT, Andrew Mak CLA 		makandre: review?
Details | Diff
screenshot after patch is applied (26.29 KB, image/gif)
2008-05-06 14:42 EDT, Andrew Mak CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description CDE Administration CLA 2007-05-31 18:18:15 EDT 
<response_by> Noha El Ghannam at 2007.05.30.13.20.09 </response_by>
OS: Windows
Build date: 05292007
Component Name: WTP
Blocking: No
Tester Name: Noha

Steps to recreate the problem:
Goto File -> Import... Expand the Web folder, select War File and click Next. Use browse button to select HeaderTVT.war or type in the path to it. Right click on the HeaderTVT project and select Run As -> Run on server. Click finish. Expand HeaderTVT -> WebContent -> wsdl and right click on header_tvtSOAP.wsdl. Select Web Services -> Test with Web Services Explorer. Click New Operation.

Problem description:
The titles 'Actions' and 'Status' need to be right aligned for Arabic.

<response_by> Brent Hepburn at 2007.05.31.16.34.12 </response_by>
This article was reassigned from Category:''TVT Testcases''.

<response_by> Brent Hepburn at 2007.05.31.16.43.34 </response_by>
Changed the status of TCT entry.
Comment 1 CDE Administration CLA 2007-05-31 18:18:23 EDT 
Created attachment 69629 [details]
11.002240.jpg
Comment 2 CDE Administration CLA 2007-05-31 18:18:27 EDT 
<cde:tctdetail>
Testcase: 11.002240
Project: WSW33
Component: CDE - Web Tools/wst.common
Priority: 3
Subject: ar: Arabic titles need to be right aligned
Article ID: 478
Originator: husseinn@eg.ibm.com
</cde:tctdetail>
Comment 3 CDE Administration CLA 2007-06-13 15:43:21 EDT 
<response_by> Noha El Ghannam at 2007.06.13.14.25.00 </response_by>
Hi,
Problem still exists in 0612 build.
Comment 4 CDE Administration CLA 2007-06-15 12:43:49 EDT 
<response_by> Noha El Ghannam at 2007.06.15.11.28.16 </response_by>
Please defer this problem to next release.
Comment 5 Kathy Chan CLA 2007-07-19 15:56:04 EDT 
Hi Gil, 

Please take a look at this TVT problem for the WSE.
Comment 6 Kathy Chan CLA 2007-08-13 17:41:28 EDT 
Retargetting to WTP 3.0.
Comment 7 Kathy Chan CLA 2008-05-02 16:07:44 EDT 
Andrew, over to you.
Comment 8 Andrew Mak CLA 2008-05-06 14:16:11 EDT 
Created attachment 98900 [details]
patch
Comment 9 Andrew Mak CLA 2008-05-06 14:42:17 EDT 
Created attachment 98911 [details]
screenshot after patch is applied

Here is a screenshot of proper alignment of the titles.  Note that I did not switch to Arabic language, but launching eclipse with -dir rtl argument will give the right-to-left orientation.

The fix itself is fairly trivial.  The right-to-left orientation is handle by eclipse already but it was not applied to the titles because those elements had align="left" attribute specified in the WSE source.  Removing that attribute allows the title to use the "default" alignment depending on ltr or rtl orientation.

This patch is very safe, it does not change any core logic of the WSE.
Comment 10 Kathy Chan CLA 2008-05-06 23:37:19 EDT 
Patch reviewed.

PMC, please approve for WTP 3.0 RC1.
Comment 11 Neil Hauge CLA 2008-05-07 11:53:02 EDT 
Approving based on the trivial nature of the fix relative to the severity of the bug.  This is very weak +1 from me.
Comment 12 Kathy Chan CLA 2008-05-08 17:30:53 EDT 
Patch committed and released to HEAD as v200805082126.
Comment 13 Andrew Mak CLA 2008-06-06 10:11:05 EDT 
Verified on wtp-S-3.0RC4-20080604210034, closing on behalf of reporter.