Bug 190001 - [refresh] Avoid unnecessary duplicate queries during drag&drop to filter
Summary: [refresh] Avoid unnecessary duplicate queries during drag&drop to filter
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 RC1   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on: 160420 164118 182574
Blocks:
  Show dependency tree
 
Reported: 2007-05-30 14:49 EDT by Martin Oberhuber CLA
Modified: 2009-05-12 13:58 EDT (History)
3 users (show)

See Also:


Attachments
patch to not refresh filter twice when handling SYSTEM_REMOTE_RESOURCE_CREATED event (1.67 KB, patch)
2009-05-12 13:57 EDT, David McKnight CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-05-30 14:49:33 EDT
+++ This bug was initially created as a clone of Bug #182574 +++

According to bug #182574 comment 7, it can happen in certain situations that drag&drop initiates duplicate jobs for getChildren(), where the 2nd query originally canceled the first one.

A workaround has been put in place to avoid the visible effects of this, but eventually the duplicate queries should be avoided.

I think the scenario could be reproduced by placing a breakpoint in the workaround code in SystemDeferredTreeContentManager v1.3 according to bug #182574 comment 12, and then performing some drag&drop to a filter. When the breakpoint is hit, a dupliate job is being canceled on behalf of the workaround.
 
The root cause for this should be found and eliminated. Perhaps it's multiple views (treeview, tableview) showing the same resources; perhaps it's some oddities in Refresh queries. Perhaps the issue will be resolved due to other fixes at the time this is finally investigated.
Comment 1 Martin Oberhuber CLA 2007-05-30 14:52:11 EDT
Actually, I'd like to see this investigated for 2.0.1 since it might affect our
commercial product.
Comment 2 Martin Oberhuber CLA 2007-05-30 16:11:11 EDT
Bug #164118 might also be related to this.
Comment 3 Martin Oberhuber CLA 2007-05-30 16:29:08 EDT
Bug #160420 might be another incarnation of this.
Comment 4 Martin Oberhuber CLA 2007-10-01 07:57:06 EDT
Bulk update target milestone 2.0.1 -> 3.0
Comment 5 David McKnight CLA 2009-05-12 13:57:30 EDT
Created attachment 135406 [details]
patch to not refresh filter twice when handling SYSTEM_REMOTE_RESOURCE_CREATED event

Using the steps provided in the defect, I discovered that the filter was being refreshed twice because, in the SystemView handling for SYSTEM_REMOTE_RESOURCE_CREATED, we refresh all filter references that yield the target object before calling refreshRemoteObject() on that target object itself.  Since the target object is also a filter reference, we're doing the refresh on it twice.
Comment 6 David McKnight CLA 2009-05-12 13:58:21 EDT
I've committed the change to cvs.