Community
Participate
Working Groups
Build ID: Source code from CVS (28.05.2007) Steps To Reproduce: I have been running Jtest's BugDetective feature on Eclipse source code from CVS (28.05.2007) and it reported a possible resource leak in org.eclipse.jdt.internal.compiler.parser.Parser.java. The stream allocated at line 443 (buildFileForTable method) is not closed after its use. I'm attaching a screenshot from BugDetective which describes the exact flow which may cause the leak. Please let me know if this is a real problem or BugDetective is mistaken. Thank you! More information:
Created attachment 68985 [details] possible leak
*** Bug 189553 has been marked as a duplicate of this bug. ***
We don't use this code anymore, but we might want to fix it anyway. Fix is trivial.
Created attachment 68988 [details] Proposed fix Philippe, do you want this one for 3.3RC3?
If we don't use the code any longer, why not simply discarding it ? Also, this isn't at all critical then... so why for 3.3 at this stage. More like hygiene for 3.4.
David, are you still using these methods or you are using the internal tool for updating the parser files ? If you don't use them, I would discard them.
I use the internal tool. The methods inside Parser cannot be discarded because this is the only way to update the parser files for someone who don't have access to the internal tool.
Maybe the best would be to make the internal tool public. Philippe, should we fix it regarding David last comment? The fix is trivial and low risk.
If trivial, then go for it. For 3.4, we probably should state on whether we keep them or make the tool public (likely the best).
David, Jérôme, Frédéric, please review.
+1 for 3.3 RC3
Pascal, could you please review this patch? Thanks.
Andrew, please review.
+1, patch will close the streams.
Released for 3.3RC3. Roman, could you please verify it using next integration build?
Verified for 3.3RC3 using I20070601-0010