Bug 189533 - [Preferences][Target] Suggest putting count beside Group check box
Summary: [Preferences][Target] Suggest putting count beside Group check box
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Brock Janiczak CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed, polish
Depends on:
Blocks:
 
Reported: 2007-05-28 21:17 EDT by Jeff McAffer CLA
Modified: 2007-08-05 15:24 EDT (History)
2 users (show)

See Also:
baumanbr: review?


Attachments
patch to org.eclipse.pde.ui (2.55 KB, patch)
2007-08-03 23:32 EDT, Brock Janiczak CLA
no flags Details | Diff
mylyn/context/zip (1.06 KB, application/octet-stream)
2007-08-05 15:23 EDT, Chris Aniszczyk CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff McAffer CLA 2007-05-28 21:17:14 EDT
in RC2

The Target Platform pref page has the list of plugins and then a count of selected vs.  available.  Below that is a check box with the label "Group plugins by location".  If you put these two chunks of text beside each other, perhaps right justifying the counts, then we would get another line of text in the plugin list.
Comment 1 Brian Bauman CLA 2007-05-29 10:51:50 EDT
Another place we could put the count is to the lower right of the plug-ins tree/table.  In the Manifest Editor (and many other places in PDE), we place the total # of elements to the lower right of the table.

Since this would affect the size of the buttons, we might also consider removing the word 'out' from the text, so it reads 'x of y selected'.  This way we don't add too much horizontal space.
Comment 2 Jeff McAffer CLA 2007-05-30 12:55:46 EDT
heck, remove "selected" as well!  anyway, putting it with the buttons does not get us any more space and runs the risk of unduly truncating the text or widening the button area (thus narrowing the plugin area).
Comment 3 Wassim Melhem CLA 2007-05-30 15:16:30 EDT
Not sure why we are nickle-and-diming here.  The Preferences dialog is maximizable/resizable.
Comment 4 Jeff McAffer CLA 2007-06-04 09:32:08 EDT
just a point of polish.  Seemed easy enough to use the blank space beside the group checkbox and avoid creating more blank space.
Comment 5 Jeff McAffer CLA 2007-06-04 09:32:33 EDT
in fact, I'll even add the polish keyword
Comment 6 Simon Archer CLA 2007-07-24 09:18:28 EDT
Another real-estate saving change would be to re-think the "Pre-defined Targets" group box.  The fact that it lurks at the bottom of the Target Platform preference page makes me think that it was bolted on in haste.  As it is today, the "Pre-defined Targets" group box is visible regardless of the tab page you're on, when really it only matters for the "plug-ins" page.  I would vote for the "Plug-ins" page to be redesigned a little to better incorporate the concept of a pre-defined target.  But maybe this should be spun off into another bug report since I would not want to de-rail bugday.  ;-)
Comment 7 Brock Janiczak CLA 2007-08-03 23:32:15 EDT
Created attachment 75374 [details]
patch to org.eclipse.pde.ui

Attached patch to move plugin count to bottom right of the tree (under the buttons).  Also changed the message to "x of y selected"
Comment 8 Chris Aniszczyk CLA 2007-08-05 15:23:35 EDT
looks clean Brock, we save a tiny bit of space on first view.

Simon can open another bug about his issue as his is a bit more complicated :P
Comment 9 Chris Aniszczyk CLA 2007-08-05 15:23:38 EDT
Created attachment 75398 [details]
mylyn/context/zip
Comment 10 Chris Aniszczyk CLA 2007-08-05 15:24:11 EDT
targeting to 3.4M1