Community
Participate
Working Groups
3.3 rc3 Adding a java breakpoints that is already in the breakpoint list but disabled, should re-enable it. Steps to reproduce: - go to the breakpoints view - click "add a java exception breakpoint" - select NullPointerException, notice that an entry is added to the view - in the view, disable the added breakpoint - click "add a java exception breakpoint" - select NullPointerException, notice that an entry is not re-enabled. This is pretty annoying since even though I may at one point have disabled the exception breakpoint, when I go back to the "add a java exception breakpoint", it is that I want this breakpoint to be enabled.
Consider post 3.3
Created attachment 153293 [details] Proposed patch Fairly simple fix by appending some code to org.eclipse.jdt.internal.debug.ui.breakpoints.AddExceptionAction.java However, I am a bit unsure about some exception handling (see comment in patched code). Hopefully someone with a little more familiarity can clear this up.
Created attachment 154272 [details] Updated Fix There were some issues with your patch: 1. Removed some unecessary logic (the javadoc for setEnabled explicitly states that it does nothing if already enabled) 2. Corrected string NLS, rather than have a constant in the class for strings (which doesn't add any benefit), Eclipse uses a localization class so that different translations can be used. Look at the patch for example usage. If you enter a literal string, it should be marked as a warning with a quick fix to open the externalization wizard that will do the work for you. 3. Handled the core exception the same way as other jobs in the class do. If there is a problem interacting with the breakpoint model the job will fail and display a status dialog to the user.
Will commit for M5.
Fixed in HEAD.
Mike, please verify.
looks fine, I applied a small update to make the breakpoint jobs system + interactive.
