Bug 189471 - [implementation] Potential reuse between source mappers
Summary: [implementation] Potential reuse between source mappers
Status: CLOSED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Jay Arthanareeswaran CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: performance
Depends on:
Blocks:
 
Reported: 2007-05-28 12:28 EDT by Philipe Mulet CLA
Modified: 2019-08-30 13:01 EDT (History)
1 user (show)

See Also:


Attachments
Draft patch (10.52 KB, patch)
2012-03-21 02:34 EDT, Jay Arthanareeswaran CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2007-05-28 12:28:13 EDT
Build 3.3rc2

Various JARs may point at the same source attachment zip (e.g. pieces from JRE container all point at same src.zip). 
Seems like there is some potential for sharing there (like inferred roots, pkg tables, ...).
Comment 1 Olivier Thomann CLA 2011-03-15 11:35:30 EDT
Some caching for roots already exists.
Jay, please check if this is still an issue. Might just need to be closed as WORKSFORME.
Comment 2 Jay Arthanareeswaran CLA 2012-03-19 04:00:34 EDT
It's true that package fragment roots are cached. However, the source mappers themselves are not reused and there is one instance in memory for each root. While caching is possible here, I need to find out how helpful it would be. I will investigate this.
Comment 3 Jay Arthanareeswaran CLA 2012-03-21 02:34:16 EDT
Created attachment 212969 [details]
Draft patch

This patch lets us cache/reuse source mappers for same source attachment across roots. There are about 14 tests failing with this patch. Obviously the patch has bugs. The patch neither trivial nor do I have any numbers on performance improvements yet. And since we are already in M7, I will revisit this later.
Comment 4 Eclipse Genie CLA 2019-08-30 13:01:02 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.