Bug 189284 - [clean up] Clean Up wizard allows to Finish with 0 or >1 selected profiles
Summary: [clean up] Clean Up wizard allows to Finish with 0 or >1 selected profiles
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Benno Baumgartner CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2007-05-26 05:49 EDT by Dani Megert CLA
Modified: 2007-07-11 12:47 EDT (History)
0 users

See Also:

Attachments
fix (1.20 KB, patch)
2007-05-29 04:05 EDT, Benno Baumgartner CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2007-05-26 05:49:53 EDT 
3.3 RC2

Found while verifying bug 188910.

The Clean Up wizard allows to Finish with 0 or >1 selected profiles. This is not good as the user has no clue which one got applied.

As this is probably an easy fix I suggest to fix for RC3.
Comment 1 Benno Baumgartner CLA 2007-05-29 04:01:23 EDT 
Selecting an item in the table has only an effect for the 'Configure...' button, this works as specified. The table informs the user which profiles are used for which project. 

However, multi selection in the table is not necessary and can be disabled, not sure if this is RC3 though. Dani, I would need two +1 from two component leads... Your call.
Comment 2 Benno Baumgartner CLA 2007-05-29 04:05:39 EDT 
Created attachment 69009 [details]
fix
Comment 3 Dani Megert CLA 2007-05-29 04:45:41 EDT 
> multi selection in the table is not necessary 
And what's the point of having no selection?

>. Your call.
Not really. Martin will have to promote it for RC3 and then I'll give my OK.
Comment 4 Benno Baumgartner CLA 2007-05-29 04:52:21 EDT 
(In reply to comment #3)
> > multi selection in the table is not necessary 
> And what's the point of having no selection?

The patch also fixes the no selection case: Patch makes sure that exactly one item is selected at all time.
 
> >. Your call.
> Not really. Martin will have to promote it for RC3 and then I'll give my OK.
> 

Aha, ok, sorry Martin...
Comment 5 Martin Aeschlimann CLA 2007-05-29 08:34:02 EDT 
I think this doesn't qualify as a critical fix, so we should fix this in 3.4.
Comment 6 Benno Baumgartner CLA 2007-07-11 12:47:51 EDT 
Fixed > N20070707-0010