Bug 189150 - Incorrect Right Click Menu in Scratchpad after Clear Action Used
Summary: Incorrect Right Click Menu in Scratchpad after Clear Action Used
Status: CLOSED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.0.1   Edit
Assignee: Kushal Munir CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-05-25 10:56 EDT by Kevin Doyle CLA
Modified: 2011-05-25 07:49 EDT (History)
1 user (show)

See Also:
ddykstal.eclipse: review+

Attachments
After performing a clear operation the selection is set to null (4.17 KB, patch)
2007-05-25 11:27 EDT, Kevin Doyle CLA 		no flags Details | Diff
Updated to includes comments on _selectionFlagsUpdated = false (4.49 KB, patch)
2007-06-05 10:00 EDT, Kevin Doyle CLA 		no flags Details | Diff
Updated for latest code changes (4.52 KB, patch)
2007-07-04 13:47 EDT, Kevin Doyle CLA 		mober.at+eclipse: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Doyle CLA 2007-05-25 10:56:14 EDT 
After using the clear selection and clear all actions in the scratchpad and right clicking, the context menu is incorrect.

The original right click menu is also incorrect before adding objects to the scratchpad, as Refresh doesn't show up and Properties shouldn't be displayed.

-----------Enter bugs above this line-----------
TM 2.0RC1 Testing
installation : eclipse-SDK-3.3M7
RSE install  : I20070524-0915
java.runtime : Sun 1.5.0_11-b03
os.name:     : Windows XP, Service Pack 2
------------------------------------------------
Comment 1 Kevin Doyle CLA 2007-05-25 11:27:46 EDT 
Created attachment 68791 [details]
After performing a clear operation the selection is set to null

This patch sets the selection to null after performing the clear operations and displays the refresh action on first right click in the empty scratchpad.

Kushal and I reviewed this patch earlier.

I will create a separate bug for the preference action being displayed in the right click menu when nothing is selected as it also appears on text.

Legal Message: I, Kevin Doyle, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer, IBM Canada Ltd. to make this
contribution under the EPL.
Comment 2 Kevin Doyle CLA 2007-05-25 11:35:28 EDT 
bug 189162 has been opened about preference action being displayed with nothing selected or a string of text being selected.
Comment 3 David Dykstal CLA 2007-06-04 21:16:43 EDT 
Please add some non-javadoc comments describing what the _selectionFlagsUpdated does and why setting it false should force a rescan of the selections. Other than that it looks good.
Comment 4 Kevin Doyle CLA 2007-06-05 10:00:42 EDT 
Created attachment 70132 [details]
Updated to includes comments on _selectionFlagsUpdated = false

Legal Message: I, Kevin Doyle, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer, IBM Canada Ltd. to make this
contribution under the EPL.
Comment 5 Kevin Doyle CLA 2007-07-04 13:47:42 EDT 
Created attachment 73047 [details]
Updated for latest code changes

Legal Message: I, Kevin Doyle, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer, IBM Canada Ltd. to make this
contribution under the EPL.
Comment 6 David McKnight CLA 2007-07-04 13:52:54 EDT 
I've committed Kevin's patch for this.
Comment 7 Martin Oberhuber CLA 2007-07-04 14:48:16 EDT 
Dave can you set the "contributed" flag for bug #194463 as well?
Comment 8 Kevin Doyle CLA 2007-07-05 13:49:55 EDT 
Verified with I20070705-0600.