Bug 188876 - [assist] Proposals inside an import statement shouldn't be fully qualified
Summary: [assist] Proposals inside an import statement shouldn't be fully qualified
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-24 07:02 EDT by David Audel CLA
Modified: 2007-08-03 08:32 EDT (History)
1 user (show)

See Also:

Attachments
Proposed fix (16.56 KB, patch)
2007-07-11 04:44 EDT, David Audel CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Audel CLA 2007-05-24 07:02:45 EDT 
From bug 188247.

Perhaps the fix proposed in bug 188247 comment 7 should generalized for all kinds of proposals inside an import statement.

I don't see any reason why the completion string should be fully qualified for type ref and method ref proposals.
Comment 1 David Audel CLA 2007-07-11 04:44:28 EDT 
Created attachment 73515 [details]
Proposed fix

The proposals of TYPE_REF and METHOD_NAME_REFERENCE are unqualified with this patch.
This patch doesn't change the current behavior for PACKAGE_REF because the problem is slightly different for package. I entered a specific bug for this issue (bug 196119)
Comment 2 David Audel CLA 2007-07-11 04:54:11 EDT 
Released for 3.4M1

Tests updated
  CompletionTests#testCompletionFindImport2()

  CompletionTest_1_5#
    test0071() -> test0074()
    test0211() -> test0213()
    test0250()
    test0330() -> test0331()

Entered bug 196119 about PACKAGE_REF
Comment 3 Frederic Fusier CLA 2007-08-03 08:32:26 EDT 
Without helpful test cases to verify the functional change, I assumed it's working based on changes made in tests I saw in the attached patch.
So, considered as verified for 3.4M1 using build I20070802-0800...