Bug 188184 - [Preferences][Target] Allow multi-select for enable and disable of plugins in target platform
Summary: [Preferences][Target] Allow multi-select for enable and disable of plugins in...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M3   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2007-05-21 19:51 EDT by Mike Boyersmith CLA
Modified: 2007-10-29 17:06 EDT (History)
3 users (show)

See Also:
baumanbr: review+


Attachments
Patch for review (12.84 KB, patch)
2007-10-02 11:56 EDT, Curtis Windatt CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Boyersmith CLA 2007-05-21 19:51:46 EDT
Problem: Target Platform setup page. The problem is that when you have 1500+ plugins enabling and disabling portions of them one by one, really becomes a pain. 

Solution: Allow multi-select and then enable disable to turn on or off chucks of plugins. 

This will make development much smoother.
Comment 1 Curtis Windatt CLA 2007-10-02 11:56:20 EDT
Created attachment 79558 [details]
Patch for review

Patch adds two new buttons to the tab.  Also adds basic javadoc comments to most of the class.

Notes:
- The strings are not externalized.
- The names might need to be changed, buttons are currently "Enable Selected" "Disable Selected" "Enable All" and "Disable All".  I couldn't come up with a good naming scheme.
- Should this code be reused (or duplicated) in the plug-in tab for launch configs?
- Will the help need to be updated?
Comment 2 Chris Aniszczyk CLA 2007-10-02 12:24:42 EDT
you like to break the target platform page brian ;p
Comment 3 Brian Bauman CLA 2007-10-02 16:54:05 EDT
I like it Curtis.  Thanks for enhancing our usability for people developing against large platforms.

I committed the code with just a few changes:
1. externalize the new button labels
2. added mnemonics for the enable/disable all buttons
3. carried over the select when the user flipped between the tree and list view
4. added support for enable/disable selected buttons when the selection contains a parent folder in the tree view.  It will now enable/disable all the children of the folder if it is in the selection.

Patch released and will be included in 3.4M3
Comment 4 Darin Wright CLA 2007-10-29 17:06:50 EDT
Verified.