Bug 187646 - [Target][Editors] Content page - Cannot Cntrl-A to select all, get rid of "Remove All"
Summary: [Target][Editors] Content page - Cannot Cntrl-A to select all, get rid of "Re...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 3.4 M2   Edit
Assignee: bartosz michalik CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2007-05-17 14:32 EDT by Kevin McGuire CLA
Modified: 2007-08-27 12:16 EDT (History)
4 users (show)

See Also:

Attachments
ctrl+A for content page (1.64 KB, patch)
2007-08-27 05:56 EDT, bartosz michalik CLA 		no flags Details | Diff
mylyn/context/zip (1.31 KB, application/octet-stream)
2007-08-27 11:37 EDT, Chris Aniszczyk CLA 		no flags Details
doGlobalAction updated (1007 bytes, text/plain)
2007-08-27 12:11 EDT, bartosz michalik CLA 		no flags Details
mylyn/context/zip (1.18 KB, application/octet-stream)
2007-08-27 12:16 EDT, Chris Aniszczyk CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin McGuire CLA 2007-05-17 14:32:38 EDT 
3.3 N0516

In the Content page of the Target editor, the plugin list does not support "Cntrl-A" to select all.

If this was supported and via popup menu, then you could get rid of the "Remove All" button and menu.  I suggest this because for one it gets rid of one button, but more importantly it makes it two steps to remove all which is a good safety in case user picks wrong button.  Especially nice since removal does not support undo.

I think it would also be more consistent with other areas in Eclipse although not sure.
Comment 1 Brian Bauman CLA 2007-06-14 12:21:46 EDT 
Adding the ctrl+A selection seems like a fine idea.  I personally like all the short cut keys so I can understand the value here.  

We will have to see about removing the button.  I want to make sure we are as consistent as possible with our editors and other Eclipse editors.
Comment 2 bartosz michalik CLA 2007-08-07 11:41:01 EDT 
I will look on this issue.
Comment 3 Chris Aniszczyk CLA 2007-08-07 11:44:32 EDT 
It's yours :)
Comment 4 bartosz michalik CLA 2007-08-27 05:56:07 EDT 
Created attachment 77020 [details]
ctrl+A for content page

sorry for such delay but I've been on vacations.
if "select all" support is planned for other editor parts I can think more genetic solution.
Comment 5 Chris Aniszczyk CLA 2007-08-27 10:30:42 EDT 
I'll look at this... thanks Bartosz :D
Comment 6 Brian Bauman CLA 2007-08-27 11:32:18 EDT 
Hi Bartosz, thanks for the patch.  I hope you enjoyed you vacation.  They always seem to be over too quickly.

I like the patch but, there is a more simple way to solve this problem (without creating an inner class).  Check out org.eclipse.pde.internal.ui.editor.feature.IncludedFeaturesSection.  Check out how it listens to the select all key stroke.  Also note, you can simplify the handleSelectAll() function for the ContentSection to really just one line :)

If you have questions, please don't hesitate to ask.  Thanks again for your help fixing this bug, we do appreciate it!
Comment 7 Chris Aniszczyk CLA 2007-08-27 11:34:37 EDT 
updating milestone
Comment 8 Chris Aniszczyk CLA 2007-08-27 11:37:30 EDT 
I attached a context to help you out. Look at IncludedFeaturesSection.doGlobalAction(...)
Comment 9 Chris Aniszczyk CLA 2007-08-27 11:37:35 EDT 
Created attachment 77038 [details]
mylyn/context/zip
Comment 10 bartosz michalik CLA 2007-08-27 12:11:28 EDT 
Created attachment 77047 [details]
doGlobalAction updated

Chris thanks for mylyn context :)
I've corrected as U suggested. It looks simple now :)
Comment 11 Chris Aniszczyk CLA 2007-08-27 12:16:04 EDT 
looks good now :)

Thank you!
Comment 12 Chris Aniszczyk CLA 2007-08-27 12:16:07 EDT 
Created attachment 77049 [details]
mylyn/context/zip