Bug 187288 - TVT33: Capitalization problems in code style
Summary: TVT33: Capitalization problems in code style
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 4.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.0 RC2   Edit
Assignee: Vivian Kong CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-05-16 11:27 EDT by Brent Hepburn CLA
Modified: 2009-01-12 09:15 EST (History)
4 users (show)

See Also:


Attachments
Parameters string (92.32 KB, image/pjpeg)
2007-05-16 11:28 EDT, Brent Hepburn CLA
no flags Details
Proposed patch (11.54 KB, patch)
2007-05-17 13:47 EDT, Jason Montojo CLA
bjorn.freeman-benson: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Hepburn CLA 2007-05-16 11:27:02 EDT
Filename: eclipse/plugins/org.eclipse.cdt.ui/org/eclipse/cdt/internal/ui/preferences/formatter/FormatterMessages.properties

Strings:
LineWrappingTabPage_parameters=	Parameters
LineWrappingTabPage_group=Settings for {0}

Steps to reproduce:
1.	Window -> Preferences
2.	C++ -> Code Style
3.	Edit…
4.	Line Wrapping tab (see screenshot)

Problem:

It looks like you are trying to re-use the parameters string with the "Settings for" string.  The problem with this is you may be changing the string to all lowercase, which is a problem in some languages (such as German in which nouns are capitalized).  If you notice that the parameters string is capitalized in the properties file but it is displayed in lowercase.  We suggest creating a second parameter string so the specific language can capitalize the string if needed.  Thanks.
Comment 1 Brent Hepburn CLA 2007-05-16 11:28:17 EDT
Created attachment 67425 [details]
Parameters string
Comment 2 Jason Montojo CLA 2007-05-17 13:25:57 EDT
I'll take this.
Comment 3 Jason Montojo CLA 2007-05-17 13:47:26 EDT
Created attachment 67686 [details]
Proposed patch

This patch adds separate message strings for what appears in the tree view and what appears after "Settings for".
Comment 4 Vivian Kong CLA 2007-05-17 14:51:17 EDT
Made some minor changes to the patch and applied to HEAD.  Thanks Jay!