Community
Participate
Working Groups
When right clicking on a folder that you don't have write permission to, New File/Folder and Paste should be disabled. Paste action is already disabled on FTP/DStore Linux connections. It's disabled on Windows if you make a folder read-only inside RSE. If you make a folder read-only outside RSE then RSE doesn't know it's read-only. Even if you make a folder read-only in RSE you can still create files/folders because windows write permission is never set to disabled. -----------Enter bugs above this line----------- TM 2.0M7 Testing installation : eclipse-SDK-3.3M7 RSE install : I20070514-1630 java.runtime : Sun 1.5.0_11-b03 os.name: : Windows XP, Service Pack 2 ------------------------------------------------
I've put in a chance to SystemViewRemoteFileAdapter so that New File/Folder, rename and move are not available when the folder is read-only. This works for dstore, however, for ftp and ssh, IHostFile.canWrite() is returning true for read-only files. Martin, do you expect this to happen for ssh?
(In reply to comment #1) > however, for ftp and ssh, IHostFile.canWrite() is returning true for > read-only files. Martin, do you expect this to happen for ssh? I checked the code, and permissions are properly set in SftpFileService#makeHostFile() line 731ff. Are you sure that the file you checked was really read-only? Could you perhaps try again, with a breakpoint on SftpFileService line 731? I really cannot see how this could fail.
Remember for SSH that setting a file/folder read only has issue's. It works but it doesn't update the file till you refresh the grand parent. Once I had a folder that was read-only and recognized as read-only in the Properties, I no longer saw New File/Folder. Should it be disabling New File and Folder or just not displaying them on a read only folder?
I just tried it now (by changing permissions to a-w) and it seems to work fine on ssh for me now. I'm not sure why it hadn't worked before.
(In reply to comment #3) > Remember for SSH that setting a file/folder read only has issue's. It works > but it doesn't update the file till you refresh the grand parent. There's a separate bug for this, isn't it? > Should it be disabling New File and Folder or just not displaying them on a > read only folder? I think the actions should be there but disabled. That way the user knows that it should be possible to create a new file / folder but something must be done to enable it (i.e. set the folder writable). Can we set this resolved now?
(In reply to comment #5) > (In reply to comment #3) > > Remember for SSH that setting a file/folder read only has issue's. It works > > but it doesn't update the file till you refresh the grand parent. > > There's a separate bug for this, isn't it? Yes, bug 190904. > > > Should it be disabling New File and Folder or just not displaying them on a > > read only folder? > > I think the actions should be there but disabled. That way the user knows that > it should be possible to create a new file / folder but something must be done > to enable it (i.e. set the folder writable). > > Can we set this resolved now? > Currently the actions are gone. If we want them to be there but disabled then this should remain open. I think they should be there, but be disabled.
Marking this as invalid now since, on Windows, these operations are valid. Bug 203455 is opened to address the system-specific cases.
