Bug 187014 - [apidoc] Mark SystemSelectRemoteFileOrFolderDialog deprecated
Summary: [apidoc] Mark SystemSelectRemoteFileOrFolderDialog deprecated
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 2.0   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 221138
  Show dependency tree
 
Reported: 2007-05-15 10:32 EDT by Martin Oberhuber CLA
Modified: 2008-08-13 13:21 EDT (History)
0 users

See Also:
mober.at+eclipse: pmc_approved+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-05-15 10:32:20 EDT
SystemSelectRemoteFileOrFolderDialog is an old implementation and should be replaced by the newer versions, based on SystemRemoteResourceDialog. At the same time, associated classes (e.g. SystemSelectRemoteFileOrFolderForm) should be removed.

Note that the ISV Docs currently reference the old version in uiDialogsAPI.html.

If we do not remove the class for 2.0, we should at least replace the reference in the ISV Docs, and mark the class deprecated such that clients building software on top of TM 2.0 do not use the old class.
Comment 1 Martin Oberhuber CLA 2007-05-15 10:34:52 EDT
Note that the older implementation is also buggy, for instance it does not support connecting properly (see bug #182202 comment 7).
Comment 2 Martin Oberhuber CLA 2007-05-30 13:23:56 EDT
I approve removal of all obsolete code. Note that there is also another bug asking for removal of the whole family of obsolete actions and dialogs, including SystemSelectRemoteFileOrFolderDialog.
Comment 3 Martin Oberhuber CLA 2007-06-06 06:49:37 EDT
If we cannot get rid of the old impl due to time constraints we should mark it deprecated.
Comment 4 David McKnight CLA 2007-06-07 11:10:18 EDT
This stuff is still used for the save-as dialog (i.e. for upload conflicts).  The save as dialog should change to use SystemRemoteFileDialog if possible (although I'm not sure if there's additional functionality needed for the SystemRemoteFileDialog in this case).
Comment 5 Martin Oberhuber CLA 2007-06-11 10:02:00 EDT
I don't think we should change the API any more if not absolutely necessary. 
The SystemSelectRemoteFileOrFolderDialog seems to be unwanted but not detrimental.

We should mark it deprecated in this release only - there's more things we need to do for 2.0. In the deprecated note, please point users to the correct class to be used.

Targeting RC4 since doc-only change is intended.
Comment 6 David McKnight CLA 2007-06-19 13:11:14 EDT
I've committed the change for this.
Comment 7 Martin Oberhuber CLA 2008-08-13 13:21:09 EDT
[target cleanup] 2.0 RC4 was the original target milestone for this bug