Community
Participate
Working Groups
SystemSelectRemoteFileOrFolderDialog is an old implementation and should be replaced by the newer versions, based on SystemRemoteResourceDialog. At the same time, associated classes (e.g. SystemSelectRemoteFileOrFolderForm) should be removed. Note that the ISV Docs currently reference the old version in uiDialogsAPI.html. If we do not remove the class for 2.0, we should at least replace the reference in the ISV Docs, and mark the class deprecated such that clients building software on top of TM 2.0 do not use the old class.
Note that the older implementation is also buggy, for instance it does not support connecting properly (see bug #182202 comment 7).
I approve removal of all obsolete code. Note that there is also another bug asking for removal of the whole family of obsolete actions and dialogs, including SystemSelectRemoteFileOrFolderDialog.
If we cannot get rid of the old impl due to time constraints we should mark it deprecated.
This stuff is still used for the save-as dialog (i.e. for upload conflicts). The save as dialog should change to use SystemRemoteFileDialog if possible (although I'm not sure if there's additional functionality needed for the SystemRemoteFileDialog in this case).
I don't think we should change the API any more if not absolutely necessary. The SystemSelectRemoteFileOrFolderDialog seems to be unwanted but not detrimental. We should mark it deprecated in this release only - there's more things we need to do for 2.0. In the deprecated note, please point users to the correct class to be used. Targeting RC4 since doc-only change is intended.
I've committed the change for this.
[target cleanup] 2.0 RC4 was the original target milestone for this bug